From cff19ae16b7d07b9f2c9facc911f79bb266f22c4 Mon Sep 17 00:00:00 2001 From: MattOckleton Date: Thu, 12 Mar 2026 12:49:11 +0100 Subject: [PATCH 1/3] fixes to jetCorrelationD0.cxx task --- PWGJE/Tasks/jetCorrelationD0.cxx | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/PWGJE/Tasks/jetCorrelationD0.cxx b/PWGJE/Tasks/jetCorrelationD0.cxx index 504928dd56b..193f04aade7 100644 --- a/PWGJE/Tasks/jetCorrelationD0.cxx +++ b/PWGJE/Tasks/jetCorrelationD0.cxx @@ -27,10 +27,6 @@ #include "Framework/HistogramRegistry.h" #include "Framework/Logger.h" #include "Framework/runDataProcessing.h" -#include -#include - -#include #include #include @@ -103,8 +99,8 @@ DECLARE_SOA_TABLE(D0McPTables, "AOD", "D0MCPARTICLELEVELTABLE", namespace jetInfo { // D0 tables -DECLARE_SOA_INDEX_COLUMN(D0DataTable, d0Data); -DECLARE_SOA_INDEX_COLUMN(D0McPTable, d0MCP); +DECLARE_SOA_INDEX_COLUMN(D0DataTable, d0DataTable); +DECLARE_SOA_INDEX_COLUMN(D0McPTable, d0McPTable); // Jet DECLARE_SOA_COLUMN(JetPt, jetPt, float); DECLARE_SOA_COLUMN(JetEta, jetEta, float); @@ -202,7 +198,7 @@ struct JetCorrelationD0 { { for (const auto& jetBase : jetsBase) { if (jetBase.has_matchedJetGeo()) { // geometric matching - for (auto& jetTag : jetBase.template matchedJetGeo_as>()) { + for (auto const& jetTag : jetBase.template matchedJetGeo_as>()) { registry.fill(HIST("hPtMatched"), jetBase.pt() - (rho * jetBase.area()), jetTag.pt(), weight); registry.fill(HIST("hPtMatched1d"), jetTag.pt(), weight); registry.fill(HIST("hPhiMatched"), jetBase.phi(), jetTag.phi(), weight); @@ -280,7 +276,7 @@ struct JetCorrelationD0 { continue; } float dphi = RecoDecay::constrainAngle(jet.phi() - d0Candidate.phi()); - if (abs(dphi - M_PI) > (M_PI / 2)) { // this is quite loose instead of pi/2 could do 0.6 + if (std::abs(dphi - o2::constants::math::PI) > (o2::constants::math::PI / 2)) { // this is quite loose instead of pi/2 could do 0.6 continue; } fillJetHistograms(jet, dphi); @@ -323,7 +319,7 @@ struct JetCorrelationD0 { continue; } float dphi = RecoDecay::constrainAngle(jet.phi() - d0Candidate.phi()); - if (abs(dphi - M_PI) > (M_PI / 2)) { // this is quite loose instead of pi/2 could do 0.6 + if (std::abs(dphi - o2::constants::math::PI) > (o2::constants::math::PI / 2)) { // this is quite loose instead of pi/2 could do 0.6 continue; } fillJetHistograms(jet, dphi); @@ -362,7 +358,7 @@ struct JetCorrelationD0 { continue; } float dphi = RecoDecay::constrainAngle(jet.phi() - d0MCPCandidate.phi()); - if (abs(dphi - M_PI) > (M_PI / 2)) { + if (std::abs(dphi - o2::constants::math::PI) > (o2::constants::math::PI / 2)) { continue; } fillJetHistograms(jet, dphi); From 546ac11bb48769834c1cbb3d85fedcdcaa5555ca Mon Sep 17 00:00:00 2001 From: MattOckleton Date: Thu, 12 Mar 2026 14:33:37 +0100 Subject: [PATCH 2/3] Updating columns for jetCorrelation D0 task --- PWGJE/Tasks/jetCorrelationD0.cxx | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/PWGJE/Tasks/jetCorrelationD0.cxx b/PWGJE/Tasks/jetCorrelationD0.cxx index 193f04aade7..bb9dc2609e2 100644 --- a/PWGJE/Tasks/jetCorrelationD0.cxx +++ b/PWGJE/Tasks/jetCorrelationD0.cxx @@ -53,8 +53,10 @@ DECLARE_SOA_TABLE(McCollisionTables, "AOD", "MCCOLLINFOTABLE", namespace collisionInfo { -DECLARE_SOA_INDEX_COLUMN(CollisionTable, collisionTable); -DECLARE_SOA_INDEX_COLUMN(McCollisionTable, mcCollisionTable); +//DECLARE_SOA_INDEX_COLUMN(CollisionTable, collisionTable); +DECLARE_SOA_INDEX_COLUMN_CUSTOM(CollisionTable, collisionTable, "COLLINFOTABLES"); +//DECLARE_SOA_INDEX_COLUMN(McCollisionTable, mcCollisionTable); +DECLARE_SOA_INDEX_COLUMN_CUSTOM(McCollisionTable, mcCollisionTable, "MCCOLLINFOTABLES"); } // namespace collisionInfo namespace d0Info { @@ -87,7 +89,7 @@ DECLARE_SOA_TABLE(D0DataTables, "AOD", "D0DATATABLE", d0Info::D0Phi, d0Info::D0Y); -DECLARE_SOA_TABLE(D0McPTables, "AOD", "D0MCPARTICLELEVELTABLE", +DECLARE_SOA_TABLE(D0McPTables, "AOD", "D0MCPTABLE", o2::soa::Index<>, collisionInfo::McCollisionTableId, d0Info::D0McOrigin, From ecc9beaef142c544aadae18810e6e776fb01a9dd Mon Sep 17 00:00:00 2001 From: MattOckleton Date: Thu, 12 Mar 2026 14:34:17 +0100 Subject: [PATCH 3/3] Formatting columns for jetCorrelation D0 task --- PWGJE/Tasks/jetCorrelationD0.cxx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/PWGJE/Tasks/jetCorrelationD0.cxx b/PWGJE/Tasks/jetCorrelationD0.cxx index bb9dc2609e2..22c08b9b272 100644 --- a/PWGJE/Tasks/jetCorrelationD0.cxx +++ b/PWGJE/Tasks/jetCorrelationD0.cxx @@ -53,9 +53,9 @@ DECLARE_SOA_TABLE(McCollisionTables, "AOD", "MCCOLLINFOTABLE", namespace collisionInfo { -//DECLARE_SOA_INDEX_COLUMN(CollisionTable, collisionTable); +// DECLARE_SOA_INDEX_COLUMN(CollisionTable, collisionTable); DECLARE_SOA_INDEX_COLUMN_CUSTOM(CollisionTable, collisionTable, "COLLINFOTABLES"); -//DECLARE_SOA_INDEX_COLUMN(McCollisionTable, mcCollisionTable); +// DECLARE_SOA_INDEX_COLUMN(McCollisionTable, mcCollisionTable); DECLARE_SOA_INDEX_COLUMN_CUSTOM(McCollisionTable, mcCollisionTable, "MCCOLLINFOTABLES"); } // namespace collisionInfo namespace d0Info