From dbc2e3c791b41058a554414938d65db93503a0c3 Mon Sep 17 00:00:00 2001 From: jlenon7 Date: Sun, 29 Mar 2026 15:36:19 -0300 Subject: [PATCH] fix(handlers): remove logger enabled validation on errors --- package-lock.json | 4 +-- package.json | 2 +- src/handlers/AwsSqsDriverExceptionHandler.ts | 36 +++++++++---------- .../DatabaseDriverExceptionHandler.ts | 36 +++++++++---------- src/handlers/MemoryDriverExceptionHandler.ts | 36 +++++++++---------- 5 files changed, 54 insertions(+), 60 deletions(-) diff --git a/package-lock.json b/package-lock.json index 115f23f..852fa4b 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "@athenna/queue", - "version": "5.20.0", + "version": "5.21.0", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "@athenna/queue", - "version": "5.20.0", + "version": "5.21.0", "license": "MIT", "dependencies": { "@aws-sdk/client-sqs": "^3.1009.0" diff --git a/package.json b/package.json index 4f41972..db2c11d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@athenna/queue", - "version": "5.20.0", + "version": "5.21.0", "description": "The Athenna queue handler.", "license": "MIT", "author": "João Lenon ", diff --git a/src/handlers/AwsSqsDriverExceptionHandler.ts b/src/handlers/AwsSqsDriverExceptionHandler.ts index 02d5418..da53f20 100644 --- a/src/handlers/AwsSqsDriverExceptionHandler.ts +++ b/src/handlers/AwsSqsDriverExceptionHandler.ts @@ -38,25 +38,23 @@ export class AwsSqsDriverExceptionHandler extends ExceptionHandler { // @ts-ignore await super.handle({ job, error, driver, stopHeartbeat, requeueJitterMs }) - if (Config.is('worker.logger.enabled', true)) { - if (Config.is('worker.logger.prettifyException')) { - Log.channelOrVanilla('exception').error( - await error.toAthennaException().prettify() - ) - } else { - Log.channelOrVanilla('exception').error({ - msg: `failed to process job: ${error.message}`, - queue: driver.queueName, - deadletter: driver.deadletter, - name: error.name, - code: error.code, - help: error.help, - details: error.details, - metadata: error.metadata, - stack: error.stack, - job - }) - } + if (Config.is('worker.logger.prettifyException')) { + Log.channelOrVanilla('exception').error( + await error.toAthennaException().prettify() + ) + } else { + Log.channelOrVanilla('exception').error({ + msg: `failed to process job: ${error.message}`, + queue: driver.queueName, + deadletter: driver.deadletter, + name: error.name, + code: error.code, + help: error.help, + details: error.details, + metadata: error.metadata, + stack: error.stack, + job + }) } if (shouldRetry) { diff --git a/src/handlers/DatabaseDriverExceptionHandler.ts b/src/handlers/DatabaseDriverExceptionHandler.ts index e555334..f1aa7dd 100644 --- a/src/handlers/DatabaseDriverExceptionHandler.ts +++ b/src/handlers/DatabaseDriverExceptionHandler.ts @@ -30,25 +30,23 @@ export class DatabaseDriverExceptionHandler extends ExceptionHandler { // @ts-ignore await super.handle({ job, error, driver, requeueJitterMs }) - if (Config.is('worker.logger.enabled', true)) { - if (Config.is('worker.logger.prettifyException')) { - Log.channelOrVanilla('exception').error( - await error.toAthennaException().prettify() - ) - } else { - Log.channelOrVanilla('exception').error({ - msg: `failed to process job: ${error.message}`, - queue: driver.queueName, - deadletter: driver.deadletter, - name: error.name, - code: error.code, - help: error.help, - details: error.details, - metadata: error.metadata, - stack: error.stack, - job - }) - } + if (Config.is('worker.logger.prettifyException')) { + Log.channelOrVanilla('exception').error( + await error.toAthennaException().prettify() + ) + } else { + Log.channelOrVanilla('exception').error({ + msg: `failed to process job: ${error.message}`, + queue: driver.queueName, + deadletter: driver.deadletter, + name: error.name, + code: error.code, + help: error.help, + details: error.details, + metadata: error.metadata, + stack: error.stack, + job + }) } if (!shouldRetry) { diff --git a/src/handlers/MemoryDriverExceptionHandler.ts b/src/handlers/MemoryDriverExceptionHandler.ts index c10f626..852d79f 100644 --- a/src/handlers/MemoryDriverExceptionHandler.ts +++ b/src/handlers/MemoryDriverExceptionHandler.ts @@ -32,25 +32,23 @@ export class MemoryDriverExceptionHandler extends ExceptionHandler { job.reservedUntil = null - if (Config.is('worker.logger.enabled', true)) { - if (Config.is('worker.logger.prettifyException')) { - Log.channelOrVanilla('exception').error( - await error.toAthennaException().prettify() - ) - } else { - Log.channelOrVanilla('exception').error({ - msg: `failed to process job: ${error.message}`, - queue: driver.queueName, - deadletter: driver.deadletter, - name: error.name, - code: error.code, - help: error.help, - details: error.details, - metadata: error.metadata, - stack: error.stack, - job - }) - } + if (Config.is('worker.logger.prettifyException')) { + Log.channelOrVanilla('exception').error( + await error.toAthennaException().prettify() + ) + } else { + Log.channelOrVanilla('exception').error({ + msg: `failed to process job: ${error.message}`, + queue: driver.queueName, + deadletter: driver.deadletter, + name: error.name, + code: error.code, + help: error.help, + details: error.details, + metadata: error.metadata, + stack: error.stack, + job + }) } if (shouldRetry) {