From 5111c34764e83261c63271534b714bacfaf00264 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Sun, 22 Mar 2026 07:04:32 +0000 Subject: [PATCH 1/9] Created New branch for Sprint 1. --- Sprint-1/fix/median.js | 27 +++++++++++++++++++++++++++ Sprint-1/implement/dedupe.js | 5 ++++- 2 files changed, 31 insertions(+), 1 deletion(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index b22590bc6..4af63070c 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -11,4 +11,31 @@ function calculateMedian(list) { return median; } +//function calculateMedian(list) { + // Check if input is an array + if (!Array.isArray(list)) return null; + + // Filter only valid numbers + const numbers = list.filter( + (item) => typeof item === "number" && !isNaN(item) + ); + + // If no valid numbers, return null + if (numbers.length === 0) return null; + + // Sort numbers (without mutating original array) + const sorted = [...numbers].sort((a, b) => a - b); + + const middle = Math.floor(sorted.length / 2); + + // Even length → average of two middle values + if (sorted.length % 2 === 0) { + return (sorted[middle - 1] + sorted[middle]) / 2; + } + + // Odd length → middle value + return sorted[middle]; +} + +module.exports = calculateMedian; module.exports = calculateMedian; diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 781e8718a..4a66ee07a 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1 +1,4 @@ -function dedupe() {} +function dedupe(arr) { + const set = new Set(arr); + return [...set]; +} From a42c61ec6ee847689909fdb4596bbcf1c7beaf9a Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Sun, 22 Mar 2026 07:06:31 +0000 Subject: [PATCH 2/9] I imlemented a dedupe function. --- Sprint-1/implement/dedupe.js | 1 + 1 file changed, 1 insertion(+) diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 4a66ee07a..60042ed8f 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -2,3 +2,4 @@ function dedupe(arr) { const set = new Set(arr); return [...set]; } +module.exports = dedupe; \ No newline at end of file From 3d8c9020506ec1ca611c2417abfed10d7041eb67 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Sun, 22 Mar 2026 07:34:32 +0000 Subject: [PATCH 3/9] I created different test cases for dedupe empty array, arry with dublications and to return the same values if the array has no dublications. --- Sprint-1/implement/dedupe.test.js | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index d7c8e3d8e..4132b6c7c 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -16,13 +16,35 @@ E.g. dedupe([1, 2, 1]) returns [1, 2] // Given an empty array // When passed to the dedupe function // Then it should return an empty array -test.todo("given an empty array, it returns an empty array"); +describe('dedupe', () => { + + test("given an empty array, it returns an empty array", () => { + expect(dedupe([])).toEqual([]); + }); +}); // Given an array with no duplicates // When passed to the dedupe function // Then it should return a copy of the original array + test("given an array with no duplication, it returns a copy of the array", () => { + const input = [1, 2, 3]; + const result = dedupe(input); + + expect(result).toEqual([1, 2, 3]); + expect(result).not.toBe(input); + }); // Given an array of strings or numbers // When passed to the dedupe function // Then it should return a new array with duplicates removed while preserving the // first occurrence of each element from the original array. + test("removes duplicates and preserves first occurrence", () => { + expect(dedupe(['a','a','a','b','b','b','c'])) + .toEqual(['a','b','c']); + + expect(dedupe([5,1,1,2,3,2,5,8])) + .toEqual([5,1,2,3,8]); + + expect(dedupe([1,2,1])) + .toEqual([1,2]); + }); \ No newline at end of file From 5728131ff31b1fdbe1542d6a9ae8af3f9f1af828 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Sun, 22 Mar 2026 08:00:42 +0000 Subject: [PATCH 4/9] implemented a find max function. --- Sprint-1/implement/max.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index 6dd76378e..e2a43db94 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,4 +1,6 @@ -function findMax(elements) { +function findMax(arr) { + return arr.filter(item=> typeof item === 'number') + .reduce((acc, num) =>(num > acc ? num : acc) , -Infinity); } module.exports = findMax; From 283192721e66c539e7f012c91e282a581494082e Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Sun, 22 Mar 2026 08:08:31 +0000 Subject: [PATCH 5/9] I wrote diffrent test cases to find the max in cases for empty array , arry with nigative and positive number, arry with non numerical values and arry with decimels. --- Sprint-1/implement/max.test.js | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 82f18fd88..6401794d7 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -16,28 +16,47 @@ const findMax = require("./max.js"); // When passed to the max function // Then it should return -Infinity // Delete this test.todo and replace it with a test. -test.todo("given an empty array, returns -Infinity"); - +describe ('max function', ()=> { + test ("given an empty array, returns -Infinity", () => { + expect(findMax([])).toBe(-Infinity) + }); +}) // Given an array with one number // When passed to the max function // Then it should return that number + test("given an array with one number, returns that number", () => { + expect(findMax([42])).toBe(42); + }); // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall +test("array with both positive and negative numbers, returns the largest", () => { + expect(findMax([-10, 0, 5, 20, -5])).toBe(20); + }); // Given an array with just negative numbers // When passed to the max function // Then it should return the closest one to zero - + test("array with only negative numbers, returns the closest to zero", () => { + expect(findMax([-10, -5, -20])).toBe(-5); + }); // Given an array with decimal numbers // When passed to the max function // Then it should return the largest decimal number + test("array with decimal numbers, returns the largest decimal", () => { + expect(findMax([1.5, 2.7, 0.3])).toBe(2.7); + }); // Given an array with non-number values // When passed to the max function // Then it should return the max and ignore non-numeric values - + test("array with non-number values, ignores non-numeric and returns max number", () => { + expect(findMax(['hey', 10, 'hi', 60, 10])).toBe(60); + }); // Given an array with only non-number values // When passed to the max function // Then it should return the least surprising value given how it behaves for all other inputs + test("array with only non-number values, returns -Infinity", () => { + expect(findMax(['a', 'b', null, {}])).toBe(-Infinity); + }); From a81d757612e64ea85e9cdf7b1fce181d0cdc6a02 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Mon, 23 Mar 2026 12:19:24 +0000 Subject: [PATCH 6/9] I implemented a function that gets the sum fo the number vlaues in an array. --- Sprint-1/implement/sum.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 9062aafe3..091623377 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,4 +1,8 @@ -function sum(elements) { +function sum(arr) { + + return arr.filter(item=> typeof item === 'number') + .reduce((acc, num) => acc + num , 0); } + module.exports = sum; From 15fa2b2024fa877e83d7e545a15918f2bc19900a Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Mon, 23 Mar 2026 12:37:23 +0000 Subject: [PATCH 7/9] I wrote different test cases for the sum function. --- Sprint-1/implement/sum.test.js | 24 ++++++++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index dd0a090ca..0e29eab83 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -13,24 +13,40 @@ const sum = require("./sum.js"); // Given an empty array // When passed to the sum function // Then it should return 0 -test.todo("given an empty array, returns 0") - +describe ('sum function', ()=> { + test ("given an empty array, returns 0", () => { + expect(sum ([])).toEqual(0) + }); +}); // Given an array with just one number // When passed to the sum function // Then it should return that number + test ("given an array with one number, returns the same number", () => { + expect(sum ([1])).toEqual(1) + }); // Given an array containing negative numbers // When passed to the sum function // Then it should still return the correct total sum +test ("given an array with negative numbers, returns the correct total", () => { + expect(sum ([1,2, 3,-2])).toEqual(4) + }); // Given an array with decimal/float numbers // When passed to the sum function // Then it should return the correct total sum - +test ("given an array with decimal/float number, returns the correct total sum", () => { + expect(sum ([1,2,3,1.5,2.1])).toEqual(7.6) + }); // Given an array containing non-number values // When passed to the sum function // Then it should ignore the non-numerical values and return the sum of the numerical elements - +test ("given an array with non-number values , returns the sum of the numerical elements", () => { + expect(sum ([1, 'h', 3, 'sss', 5])).toEqual(9) + }); // Given an array with only non-number values // When passed to the sum function // Then it should return the least surprising value given how it behaves for all other inputs +test ("given an array with only non-number values , returns 0 ", () => { + expect(sum (['m', 'h', 'sss', 'hhh'])).toEqual(0) + }); From 8c070749321499b3a237edfec08579203ce20de9 Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Mon, 23 Mar 2026 12:45:13 +0000 Subject: [PATCH 8/9] re edited the expected output for the decimal/float numbers test. --- Sprint-1/implement/sum.test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index 0e29eab83..adbaa4d2e 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -36,7 +36,7 @@ test ("given an array with negative numbers, returns the correct total", () => { // When passed to the sum function // Then it should return the correct total sum test ("given an array with decimal/float number, returns the correct total sum", () => { - expect(sum ([1,2,3,1.5,2.1])).toEqual(7.6) + expect(sum ([1, 2, 3, 1.5, 2.1])).toEqual(9.6) }); // Given an array containing non-number values // When passed to the sum function From 07038412dd9b6d9be341432eff2b5ac2346ce66f Mon Sep 17 00:00:00 2001 From: Mona-Eltantawy Date: Mon, 23 Mar 2026 12:51:38 +0000 Subject: [PATCH 9/9] I fixed the implementation of the calculateMedian function and run the test and get all tests passed. --- Sprint-1/fix/median.js | 15 +++-------- Sprint-1/fix/median.test.js | 22 ++++++++++++---- Sprint-1/implement/dedupe.js | 6 ++--- Sprint-1/implement/dedupe.test.js | 30 +++++++++------------ Sprint-1/implement/max.js | 5 ++-- Sprint-1/implement/max.test.js | 44 +++++++++++++++---------------- Sprint-1/implement/sum.js | 7 +++-- Sprint-1/implement/sum.test.js | 38 +++++++++++++------------- 8 files changed, 84 insertions(+), 83 deletions(-) diff --git a/Sprint-1/fix/median.js b/Sprint-1/fix/median.js index 4af63070c..72c54dcf3 100644 --- a/Sprint-1/fix/median.js +++ b/Sprint-1/fix/median.js @@ -6,36 +6,29 @@ // or 'list' has mixed values (the function is expected to sort only numbers). function calculateMedian(list) { - const middleIndex = Math.floor(list.length / 2); - const median = list.splice(middleIndex, 1)[0]; - return median; -} - -//function calculateMedian(list) { // Check if input is an array if (!Array.isArray(list)) return null; // Filter only valid numbers const numbers = list.filter( - (item) => typeof item === "number" && !isNaN(item) + (item) => typeof item === "number" && Number.isFinite(item) ); // If no valid numbers, return null if (numbers.length === 0) return null; - // Sort numbers (without mutating original array) + // Sort without mutating original array const sorted = [...numbers].sort((a, b) => a - b); const middle = Math.floor(sorted.length / 2); - // Even length → average of two middle values + // Even length if (sorted.length % 2 === 0) { return (sorted[middle - 1] + sorted[middle]) / 2; } - // Odd length → middle value + // Odd length return sorted[middle]; } module.exports = calculateMedian; -module.exports = calculateMedian; diff --git a/Sprint-1/fix/median.test.js b/Sprint-1/fix/median.test.js index 21da654d7..c262c3776 100644 --- a/Sprint-1/fix/median.test.js +++ b/Sprint-1/fix/median.test.js @@ -13,7 +13,8 @@ describe("calculateMedian", () => { { input: [1, 2, 3, 4], expected: 2.5 }, { input: [1, 2, 3, 4, 5, 6], expected: 3.5 }, ].forEach(({ input, expected }) => - it(`returns the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`returns the median for [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); [ @@ -24,7 +25,8 @@ describe("calculateMedian", () => { { input: [110, 20, 0], expected: 20 }, { input: [6, -2, 2, 12, 14], expected: 6 }, ].forEach(({ input, expected }) => - it(`returns the correct median for unsorted array [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`returns the correct median for unsorted array [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); it("doesn't modify the input array [3, 1, 2]", () => { @@ -33,8 +35,17 @@ describe("calculateMedian", () => { expect(list).toEqual([3, 1, 2]); }); - [ 'not an array', 123, null, undefined, {}, [], ["apple", null, undefined] ].forEach(val => - it(`returns null for non-numeric array (${val})`, () => expect(calculateMedian(val)).toBe(null)) + [ + "not an array", + 123, + null, + undefined, + {}, + [], + ["apple", null, undefined], + ].forEach((val) => + it(`returns null for non-numeric array (${val})`, () => + expect(calculateMedian(val)).toBe(null)) ); [ @@ -45,6 +56,7 @@ describe("calculateMedian", () => { { input: [3, "apple", 1, null, 2, undefined, 4], expected: 2.5 }, { input: ["banana", 5, 3, "apple", 1, 4, 2], expected: 3 }, ].forEach(({ input, expected }) => - it(`filters out non-numeric values and calculates the median for [${input}]`, () => expect(calculateMedian(input)).toEqual(expected)) + it(`filters out non-numeric values and calculates the median for [${input}]`, () => + expect(calculateMedian(input)).toEqual(expected)) ); }); diff --git a/Sprint-1/implement/dedupe.js b/Sprint-1/implement/dedupe.js index 60042ed8f..3f15ede2b 100644 --- a/Sprint-1/implement/dedupe.js +++ b/Sprint-1/implement/dedupe.js @@ -1,5 +1,5 @@ function dedupe(arr) { - const set = new Set(arr); - return [...set]; + const set = new Set(arr); + return [...set]; } -module.exports = dedupe; \ No newline at end of file +module.exports = dedupe; diff --git a/Sprint-1/implement/dedupe.test.js b/Sprint-1/implement/dedupe.test.js index 4132b6c7c..7d0ab92a9 100644 --- a/Sprint-1/implement/dedupe.test.js +++ b/Sprint-1/implement/dedupe.test.js @@ -16,8 +16,7 @@ E.g. dedupe([1, 2, 1]) returns [1, 2] // Given an empty array // When passed to the dedupe function // Then it should return an empty array -describe('dedupe', () => { - +describe("dedupe", () => { test("given an empty array, it returns an empty array", () => { expect(dedupe([])).toEqual([]); }); @@ -27,24 +26,21 @@ describe('dedupe', () => { // When passed to the dedupe function // Then it should return a copy of the original array - test("given an array with no duplication, it returns a copy of the array", () => { - const input = [1, 2, 3]; - const result = dedupe(input); +test("given an array with no duplication, it returns a copy of the array", () => { + const input = [1, 2, 3]; + const result = dedupe(input); - expect(result).toEqual([1, 2, 3]); - expect(result).not.toBe(input); - }); + expect(result).toEqual([1, 2, 3]); + expect(result).not.toBe(input); +}); // Given an array of strings or numbers // When passed to the dedupe function -// Then it should return a new array with duplicates removed while preserving the +// Then it should return a new array with duplicates removed while preserving the // first occurrence of each element from the original array. - test("removes duplicates and preserves first occurrence", () => { - expect(dedupe(['a','a','a','b','b','b','c'])) - .toEqual(['a','b','c']); +test("removes duplicates and preserves first occurrence", () => { + expect(dedupe(["a", "a", "a", "b", "b", "b", "c"])).toEqual(["a", "b", "c"]); - expect(dedupe([5,1,1,2,3,2,5,8])) - .toEqual([5,1,2,3,8]); + expect(dedupe([5, 1, 1, 2, 3, 2, 5, 8])).toEqual([5, 1, 2, 3, 8]); - expect(dedupe([1,2,1])) - .toEqual([1,2]); - }); \ No newline at end of file + expect(dedupe([1, 2, 1])).toEqual([1, 2]); +}); diff --git a/Sprint-1/implement/max.js b/Sprint-1/implement/max.js index e2a43db94..add7b7693 100644 --- a/Sprint-1/implement/max.js +++ b/Sprint-1/implement/max.js @@ -1,6 +1,7 @@ function findMax(arr) { - return arr.filter(item=> typeof item === 'number') - .reduce((acc, num) =>(num > acc ? num : acc) , -Infinity); + return arr + .filter((item) => typeof item === "number") + .reduce((acc, num) => (num > acc ? num : acc), -Infinity); } module.exports = findMax; diff --git a/Sprint-1/implement/max.test.js b/Sprint-1/implement/max.test.js index 6401794d7..d349d0805 100644 --- a/Sprint-1/implement/max.test.js +++ b/Sprint-1/implement/max.test.js @@ -16,47 +16,47 @@ const findMax = require("./max.js"); // When passed to the max function // Then it should return -Infinity // Delete this test.todo and replace it with a test. -describe ('max function', ()=> { - test ("given an empty array, returns -Infinity", () => { - expect(findMax([])).toBe(-Infinity) - }); -}) +describe("max function", () => { + test("given an empty array, returns -Infinity", () => { + expect(findMax([])).toBe(-Infinity); + }); +}); // Given an array with one number // When passed to the max function // Then it should return that number - test("given an array with one number, returns that number", () => { - expect(findMax([42])).toBe(42); - }); +test("given an array with one number, returns that number", () => { + expect(findMax([42])).toBe(42); +}); // Given an array with both positive and negative numbers // When passed to the max function // Then it should return the largest number overall test("array with both positive and negative numbers, returns the largest", () => { - expect(findMax([-10, 0, 5, 20, -5])).toBe(20); - }); + expect(findMax([-10, 0, 5, 20, -5])).toBe(20); +}); // Given an array with just negative numbers // When passed to the max function // Then it should return the closest one to zero - test("array with only negative numbers, returns the closest to zero", () => { - expect(findMax([-10, -5, -20])).toBe(-5); - }); +test("array with only negative numbers, returns the closest to zero", () => { + expect(findMax([-10, -5, -20])).toBe(-5); +}); // Given an array with decimal numbers // When passed to the max function // Then it should return the largest decimal number - test("array with decimal numbers, returns the largest decimal", () => { - expect(findMax([1.5, 2.7, 0.3])).toBe(2.7); - }); +test("array with decimal numbers, returns the largest decimal", () => { + expect(findMax([1.5, 2.7, 0.3])).toBe(2.7); +}); // Given an array with non-number values // When passed to the max function // Then it should return the max and ignore non-numeric values - test("array with non-number values, ignores non-numeric and returns max number", () => { - expect(findMax(['hey', 10, 'hi', 60, 10])).toBe(60); - }); +test("array with non-number values, ignores non-numeric and returns max number", () => { + expect(findMax(["hey", 10, "hi", 60, 10])).toBe(60); +}); // Given an array with only non-number values // When passed to the max function // Then it should return the least surprising value given how it behaves for all other inputs - test("array with only non-number values, returns -Infinity", () => { - expect(findMax(['a', 'b', null, {}])).toBe(-Infinity); - }); +test("array with only non-number values, returns -Infinity", () => { + expect(findMax(["a", "b", null, {}])).toBe(-Infinity); +}); diff --git a/Sprint-1/implement/sum.js b/Sprint-1/implement/sum.js index 091623377..462df7462 100644 --- a/Sprint-1/implement/sum.js +++ b/Sprint-1/implement/sum.js @@ -1,8 +1,7 @@ function sum(arr) { - - return arr.filter(item=> typeof item === 'number') - .reduce((acc, num) => acc + num , 0); + return arr + .filter((item) => typeof item === "number") + .reduce((acc, num) => acc + num, 0); } - module.exports = sum; diff --git a/Sprint-1/implement/sum.test.js b/Sprint-1/implement/sum.test.js index adbaa4d2e..f472c9a30 100644 --- a/Sprint-1/implement/sum.test.js +++ b/Sprint-1/implement/sum.test.js @@ -13,40 +13,40 @@ const sum = require("./sum.js"); // Given an empty array // When passed to the sum function // Then it should return 0 -describe ('sum function', ()=> { - test ("given an empty array, returns 0", () => { - expect(sum ([])).toEqual(0) - }); +describe("sum function", () => { + test("given an empty array, returns 0", () => { + expect(sum([])).toEqual(0); + }); }); // Given an array with just one number // When passed to the sum function // Then it should return that number - test ("given an array with one number, returns the same number", () => { - expect(sum ([1])).toEqual(1) - }); +test("given an array with one number, returns the same number", () => { + expect(sum([1])).toEqual(1); +}); // Given an array containing negative numbers // When passed to the sum function // Then it should still return the correct total sum -test ("given an array with negative numbers, returns the correct total", () => { - expect(sum ([1,2, 3,-2])).toEqual(4) - }); +test("given an array with negative numbers, returns the correct total", () => { + expect(sum([1, 2, 3, -2])).toEqual(4); +}); // Given an array with decimal/float numbers // When passed to the sum function // Then it should return the correct total sum -test ("given an array with decimal/float number, returns the correct total sum", () => { - expect(sum ([1, 2, 3, 1.5, 2.1])).toEqual(9.6) - }); +test("given an array with decimal/float number, returns the correct total sum", () => { + expect(sum([1, 2, 3, 1.5, 2.1])).toEqual(9.6); +}); // Given an array containing non-number values // When passed to the sum function // Then it should ignore the non-numerical values and return the sum of the numerical elements -test ("given an array with non-number values , returns the sum of the numerical elements", () => { - expect(sum ([1, 'h', 3, 'sss', 5])).toEqual(9) - }); +test("given an array with non-number values , returns the sum of the numerical elements", () => { + expect(sum([1, "h", 3, "sss", 5])).toEqual(9); +}); // Given an array with only non-number values // When passed to the sum function // Then it should return the least surprising value given how it behaves for all other inputs -test ("given an array with only non-number values , returns 0 ", () => { - expect(sum (['m', 'h', 'sss', 'hhh'])).toEqual(0) - }); +test("given an array with only non-number values , returns 0 ", () => { + expect(sum(["m", "h", "sss", "hhh"])).toEqual(0); +});