From b745455f99f134a47acea143b6b19822a7917612 Mon Sep 17 00:00:00 2001 From: Alexy Pellegrini Date: Thu, 12 Mar 2026 10:55:39 +0100 Subject: [PATCH] fix(cmake): remove SOVERSION and VERSION from vtk_module_build_modules Wheels are ZIPs and ZIPs do not support symlinks. This caused SOs to be copied into three same copies in the archive. --- vtk_sdk_python_wheel_helper/VTKSDKInstallRuntimeDeps.cmake | 4 ++++ vtk_sdk_python_wheel_helper/VTKSDKModuleBuilder.cmake | 4 +--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/vtk_sdk_python_wheel_helper/VTKSDKInstallRuntimeDeps.cmake b/vtk_sdk_python_wheel_helper/VTKSDKInstallRuntimeDeps.cmake index c6558fd..c595869 100644 --- a/vtk_sdk_python_wheel_helper/VTKSDKInstallRuntimeDeps.cmake +++ b/vtk_sdk_python_wheel_helper/VTKSDKInstallRuntimeDeps.cmake @@ -12,6 +12,10 @@ `POST_EXCLUDE_REGEXES`, `POST_INCLUDE_FILES` and `POST_EXCLUDE_FILES` are forwarded to underlying `file(GET_RUNTIME_DEPENDENCIES)` + Wheels are packaged as ZIP archives. This is important as ZIPs do not support symlinks. + If one of your target links against a symlink, the symlink will be replaced by a COPY of the so/dylib. + This may significantly increase the size of your packages. + .. code-block:: cmake vtksdk_build_modules( diff --git a/vtk_sdk_python_wheel_helper/VTKSDKModuleBuilder.cmake b/vtk_sdk_python_wheel_helper/VTKSDKModuleBuilder.cmake index 7ccdc6a..e35d955 100644 --- a/vtk_sdk_python_wheel_helper/VTKSDKModuleBuilder.cmake +++ b/vtk_sdk_python_wheel_helper/VTKSDKModuleBuilder.cmake @@ -16,8 +16,8 @@ vtksdk_build_modules( [SOURCE_DIR ] [ENABLE_TESTS ] - [STATIC] [LAYOUT ] + [STATIC] [DEPENDENCIES ] MODULES ... ) @@ -131,8 +131,6 @@ function(vtksdk_build_modules package_name) RUNTIME_DESTINATION "${lib_install_dir}" LIBRARY_DESTINATION "${lib_install_dir}" UTILITY_TARGET vtk_sdk_utility_target - VERSION ${SKBUILD_PROJECT_VERSION} - SOVERSION "1" ${sdk_args_build} )