From f46d8709654f13a63e29e933dae48e422e4cc217 Mon Sep 17 00:00:00 2001 From: "george.robertson1" <50412379+georgeRobertson@users.noreply.github.com> Date: Tue, 10 Mar 2026 20:07:21 +0000 Subject: [PATCH 1/2] fix: add postcode type to model gen --- src/dve/metadata_parser/model_generator.py | 2 +- tests/testdata/demographics/basic_demographics.dischema.json | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/dve/metadata_parser/model_generator.py b/src/dve/metadata_parser/model_generator.py index 7681b7f..2706458 100644 --- a/src/dve/metadata_parser/model_generator.py +++ b/src/dve/metadata_parser/model_generator.py @@ -65,7 +65,7 @@ def constr( "conint": pyd.validate_arguments(pyd.conint), "condate": pyd.validate_arguments(pyd.condate), "condecimal": pyd.validate_arguments(pyd.condecimal), - "postcode": domain_types.Postcode, + "postcode": domain_types.postcode, "nhsnumber": domain_types.NHSNumber, "permissivenhsno": domain_types.permissive_nhs_number(), "alphanumeric": domain_types.alphanumeric, diff --git a/tests/testdata/demographics/basic_demographics.dischema.json b/tests/testdata/demographics/basic_demographics.dischema.json index e9c8944..02e4367 100644 --- a/tests/testdata/demographics/basic_demographics.dischema.json +++ b/tests/testdata/demographics/basic_demographics.dischema.json @@ -9,7 +9,9 @@ "Forename": "str", "Surname": "str", "Date_Of_Birth": "date", - "Postcode": "postcode", + "Postcode": { + "callable": "postcode" + }, "Postcode_Country": "str", "Postcode_Format_Valid": "str", "Postcode_Valid": "str" From 9b1c9c285c7796f91ca43ca316f1c0026ed61679 Mon Sep 17 00:00:00 2001 From: "george.robertson1" <50412379+georgeRobertson@users.noreply.github.com> Date: Tue, 10 Mar 2026 21:40:52 +0000 Subject: [PATCH 2/2] test: fix issue with demographics test post postcode change --- .../demographics/basic_demographics_ddb.dischema.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/testdata/demographics/basic_demographics_ddb.dischema.json b/tests/testdata/demographics/basic_demographics_ddb.dischema.json index 44e2f77..d58ace1 100644 --- a/tests/testdata/demographics/basic_demographics_ddb.dischema.json +++ b/tests/testdata/demographics/basic_demographics_ddb.dischema.json @@ -9,7 +9,9 @@ "Forename": "str", "Surname": "str", "Date_Of_Birth": "date", - "Postcode": "postcode", + "Postcode": { + "callable": "postcode" + }, "Postcode_Country": "str", "Postcode_Format_Valid": "str", "Postcode_Valid": "str"