From 062b33cee564a6a2df27e58bf4bfa6e1657cbffe Mon Sep 17 00:00:00 2001 From: bangbangsheshotmedown Date: Sun, 15 Mar 2026 11:17:42 +0100 Subject: [PATCH 1/2] Fix General's Cry to use actual APS and remove spawn time throttling --- src/Modules/CalcMirages.lua | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Modules/CalcMirages.lua b/src/Modules/CalcMirages.lua index 9d14cf1427..287006c10e 100644 --- a/src/Modules/CalcMirages.lua +++ b/src/Modules/CalcMirages.lua @@ -394,12 +394,10 @@ function calcs.mirages(env) mirageSpawnTime = mirageSpawnTime + 1 else mirageSpawnTime = mirageSpawnTime + (mainSkillOutputCache.HitTime or mainSkillOutputCache.Time) - env.player.mainSkill.skillData.timeOverride = 1 end -- This is so that it's consistent with the info message but removing this could make it more accurate numbers wise mirageSpawnTime = round(mirageSpawnTime, 2) - cooldown = m_max(cooldown, mirageSpawnTime) -- Scale dps with GC's cooldown env.player.mainSkill.skillData.dpsMultiplier = (env.player.mainSkill.skillData.dpsMultiplier or 1) * (1 / cooldown) From a54fc77e5eddf0c0327b61d2d432bd563c9ad03d Mon Sep 17 00:00:00 2001 From: LocalIdentity Date: Sun, 15 Mar 2026 23:04:00 +1100 Subject: [PATCH 2/2] Add back attack speed override Attack speed shouldn't change the DPS of the skill --- src/Modules/CalcMirages.lua | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Modules/CalcMirages.lua b/src/Modules/CalcMirages.lua index 287006c10e..bdd0f5ebb4 100644 --- a/src/Modules/CalcMirages.lua +++ b/src/Modules/CalcMirages.lua @@ -394,6 +394,7 @@ function calcs.mirages(env) mirageSpawnTime = mirageSpawnTime + 1 else mirageSpawnTime = mirageSpawnTime + (mainSkillOutputCache.HitTime or mainSkillOutputCache.Time) + env.player.mainSkill.skillData.timeOverride = 1 end -- This is so that it's consistent with the info message but removing this could make it more accurate numbers wise