From 75acb35e424a03068a046430072da1eb4874505a Mon Sep 17 00:00:00 2001 From: Keykyrios Date: Tue, 17 Mar 2026 23:58:02 +0530 Subject: [PATCH 1/2] Add issue template for revdep check failures, closes #7658 Add a YAML issue form template (.github/ISSUE_TEMPLATE/revdep_check_failure.yml) for data.table maintainers to report reverse dependency check failures that should be fixed before the next CRAN release. Based on the 'Steps to report a new revdep check problem' section of https://github.com/Rdatatable/data.table/wiki/Revdep-checks The template includes: - pre-filing verification checklist (issue reproducibility, git bisect, etc.) - required fields: affected package, problem description, failing check output, first bad commit/PR link, R version(s) affected - optional fields: minimal reproducible example, additional context - auto-labels issues with 'revdep' --- .../ISSUE_TEMPLATE/revdep_check_failure.yml | 109 ++++++++++++++++++ 1 file changed, 109 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/revdep_check_failure.yml diff --git a/.github/ISSUE_TEMPLATE/revdep_check_failure.yml b/.github/ISSUE_TEMPLATE/revdep_check_failure.yml new file mode 100644 index 0000000000..6f0c669932 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/revdep_check_failure.yml @@ -0,0 +1,109 @@ +name: Revdep check failure +description: Report a reverse dependency (revdep) check failure that should be fixed before next CRAN release +labels: ["revdep"] +body: + - type: markdown + attributes: + value: | + Use this template to report a new revdep check failure found via + [revdep checks](https://github.com/Rdatatable/data.table/wiki/Revdep-checks). + Please verify the failure is real before filing; see checklist below. + + - type: checkboxes + id: verification + attributes: + label: Pre-filing verification + description: | + Confirm the issue is real per the + [wiki guidelines](https://github.com/Rdatatable/data.table/wiki/Revdep-checks#steps-to-report-a-new-revdep-check-problem). + options: + - label: Found in more than one recent check (e.g. previous day) + required: false + - label: Occurs in both R-devel and R-release, or noted which one + required: false + - label: Result for data.table release matches result from CRAN + required: false + - label: "`git bisect` found a non-trivial first bad commit" + required: false + - label: Issue is in master (not only in release) + required: false + - label: Searched existing issues for this package and commit/PR + required: false + + - type: input + id: package + attributes: + label: Affected package + description: Name of the revdep package that fails with data.table master. + placeholder: e.g. mlr3 + validations: + required: true + + - type: textarea + id: description + attributes: + label: Problem description + description: | + Brief description of the check failure. Include what kind of failure + it is (ERROR, WARNING, NOTE) and which check stage fails + (tests, examples, vignettes, etc.). + placeholder: | + revdep shapr has new test failures due to warnings when + data.table master is installed. + validations: + required: true + + - type: textarea + id: check-output + attributes: + label: Failing check output + description: | + Paste the relevant `R CMD check` output showing the failure. + The output can be found in the + [Monsoon results](https://rcdata.nau.edu/genomic-ml/data.table-revdeps/analyze/) + or from a local revdep check. + render: text + validations: + required: true + + - type: input + id: first-bad-commit + attributes: + label: First bad commit/PR + description: | + Link to the commit or PR identified by `git bisect` as the + first bad commit (from the `first.bad.commit` column in the + Monsoon significant differences table). + placeholder: "https://github.com/Rdatatable/data.table/pull/1234" + validations: + required: true + + - type: dropdown + id: r-version + attributes: + label: R version(s) affected + description: Which R version(s) show this failure? + options: + - Both R-devel and R-release + - R-devel only + - R-release only + validations: + required: true + + - type: textarea + id: mre + attributes: + label: Minimal reproducible example + description: | + Optional. A minimal example reproducing the failure outside + the revdep package. Useful as a potential data.table test case. + render: r + + - type: textarea + id: additional-context + attributes: + label: Additional context + description: | + Any other relevant information: @mentions of the commit/PR + author(s), links to Monsoon result pages, whether the fix + should come from data.table or from the revdep package, etc. From 20340b851ff4573f29443974aa57eb2e35636c81 Mon Sep 17 00:00:00 2001 From: Keykyrios Date: Wed, 18 Mar 2026 00:57:57 +0530 Subject: [PATCH 2/2] Address tdhock review: remove checklist and R version dropdown, fix descriptions --- .../ISSUE_TEMPLATE/revdep_check_failure.yml | 43 ++----------------- 1 file changed, 4 insertions(+), 39 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/revdep_check_failure.yml b/.github/ISSUE_TEMPLATE/revdep_check_failure.yml index 6f0c669932..c62b6b09ab 100644 --- a/.github/ISSUE_TEMPLATE/revdep_check_failure.yml +++ b/.github/ISSUE_TEMPLATE/revdep_check_failure.yml @@ -7,35 +7,14 @@ body: value: | Use this template to report a new revdep check failure found via [revdep checks](https://github.com/Rdatatable/data.table/wiki/Revdep-checks). - Please verify the failure is real before filing; see checklist below. - - - type: checkboxes - id: verification - attributes: - label: Pre-filing verification - description: | - Confirm the issue is real per the - [wiki guidelines](https://github.com/Rdatatable/data.table/wiki/Revdep-checks#steps-to-report-a-new-revdep-check-problem). - options: - - label: Found in more than one recent check (e.g. previous day) - required: false - - label: Occurs in both R-devel and R-release, or noted which one - required: false - - label: Result for data.table release matches result from CRAN - required: false - - label: "`git bisect` found a non-trivial first bad commit" - required: false - - label: Issue is in master (not only in release) - required: false - - label: Searched existing issues for this package and commit/PR - required: false + Please verify the failure is real before filing; see checklist on that page. - type: input id: package attributes: label: Affected package - description: Name of the revdep package that fails with data.table master. - placeholder: e.g. mlr3 + description: Link to package dev on github. + placeholder: e.g. https://github.com/NorskRegnesentral/shapr validations: required: true @@ -47,9 +26,7 @@ body: Brief description of the check failure. Include what kind of failure it is (ERROR, WARNING, NOTE) and which check stage fails (tests, examples, vignettes, etc.). - placeholder: | - revdep shapr has new test failures due to warnings when - data.table master is installed. + placeholder: revdep shapr has new test failures. validations: required: true @@ -78,18 +55,6 @@ body: validations: required: true - - type: dropdown - id: r-version - attributes: - label: R version(s) affected - description: Which R version(s) show this failure? - options: - - Both R-devel and R-release - - R-devel only - - R-release only - validations: - required: true - - type: textarea id: mre attributes: