From 19490855ca92329f2ba5c27a91f844941fe4362c Mon Sep 17 00:00:00 2001 From: Sharon Stratsianis Date: Sun, 15 Mar 2026 23:28:46 +1100 Subject: [PATCH 1/4] added more descriptive error message for acls --- src/acl/access-groups.ts | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/src/acl/access-groups.ts b/src/acl/access-groups.ts index bf78337f..3a7d17e2 100644 --- a/src/acl/access-groups.ts +++ b/src/acl/access-groups.ts @@ -258,7 +258,15 @@ export class AccessGroups { } return this.handleDroppedUri(uri, combo, true) } else if (!agent) { - const error = ` Error: Drop fails to drop appropriate thing! ${uri}` + const detectedTypes = Object.keys(this.store.findTypeURIs(sym(uri))) + const typeDetails = detectedTypes.length > 0 + ? ` Detected RDF types: ${detectedTypes.join(', ')}` + : ' No RDF type was detected for this URI.' + const error = + `Error: Failed to add access target: ${uri} is not a recognized ACL target type.` + + ` Expected one of: vcard:WebID, vcard:Group, foaf:Person/foaf:Agent, solid:AppProvider, solid:AppProviderClass, or recognized ACL classes.` + + ' Hint: try dropping a WebID profile URI, a vcard:Group URI, or a web app origin. ' + + typeDetails debug.error(error) return Promise.reject(new Error(error)) } From b1d4405a07600084f88db57a9d91307d1e1b55b0 Mon Sep 17 00:00:00 2001 From: Timea <4144203+timea-solid@users.noreply.github.com> Date: Mon, 16 Mar 2026 09:12:07 +0100 Subject: [PATCH 2/4] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/acl/access-groups.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acl/access-groups.ts b/src/acl/access-groups.ts index 3a7d17e2..607d32b3 100644 --- a/src/acl/access-groups.ts +++ b/src/acl/access-groups.ts @@ -258,7 +258,7 @@ export class AccessGroups { } return this.handleDroppedUri(uri, combo, true) } else if (!agent) { - const detectedTypes = Object.keys(this.store.findTypeURIs(sym(uri))) + const detectedTypes = Object.keys(this.store.findTypeURIs(thing)) const typeDetails = detectedTypes.length > 0 ? ` Detected RDF types: ${detectedTypes.join(', ')}` : ' No RDF type was detected for this URI.' From bdc4495ea62e01de7499b2281b59045a59a9fc5a Mon Sep 17 00:00:00 2001 From: Timea <4144203+timea-solid@users.noreply.github.com> Date: Mon, 16 Mar 2026 09:12:29 +0100 Subject: [PATCH 3/4] Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- src/acl/access-groups.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/acl/access-groups.ts b/src/acl/access-groups.ts index 607d32b3..58b625e5 100644 --- a/src/acl/access-groups.ts +++ b/src/acl/access-groups.ts @@ -260,8 +260,8 @@ export class AccessGroups { } else if (!agent) { const detectedTypes = Object.keys(this.store.findTypeURIs(thing)) const typeDetails = detectedTypes.length > 0 - ? ` Detected RDF types: ${detectedTypes.join(', ')}` - : ' No RDF type was detected for this URI.' + ? `Detected RDF types: ${detectedTypes.join(', ')}` + : 'No RDF type was detected for this URI.' const error = `Error: Failed to add access target: ${uri} is not a recognized ACL target type.` + ` Expected one of: vcard:WebID, vcard:Group, foaf:Person/foaf:Agent, solid:AppProvider, solid:AppProviderClass, or recognized ACL classes.` + From b0f35f195625047ecf3e647b6110e1569f468589 Mon Sep 17 00:00:00 2001 From: Timea <4144203+timea-solid@users.noreply.github.com> Date: Tue, 17 Mar 2026 09:02:52 +0100 Subject: [PATCH 4/4] Update src/acl/access-groups.ts Co-authored-by: Ted Thibodeau Jr --- src/acl/access-groups.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/acl/access-groups.ts b/src/acl/access-groups.ts index 58b625e5..63f4dd7a 100644 --- a/src/acl/access-groups.ts +++ b/src/acl/access-groups.ts @@ -264,8 +264,8 @@ export class AccessGroups { : 'No RDF type was detected for this URI.' const error = `Error: Failed to add access target: ${uri} is not a recognized ACL target type.` + - ` Expected one of: vcard:WebID, vcard:Group, foaf:Person/foaf:Agent, solid:AppProvider, solid:AppProviderClass, or recognized ACL classes.` + - ' Hint: try dropping a WebID profile URI, a vcard:Group URI, or a web app origin. ' + + ` Expected one of: vcard:WebID, vcard:Group, foaf:Person, foaf:Agent, solid:AppProvider, solid:AppProviderClass, or recognized ACL classes.` + + ' Hint: try dropping a WebID profile URI, a vcard:Group URI, or a web app origin.' + typeDetails debug.error(error) return Promise.reject(new Error(error))