Skip to content

Commit 13675c4

Browse files
committed
Improve QLDoc for isTypeExprTopDown
1 parent 72bd958 commit 13675c4

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

go/ql/lib/semmle/go/Expr.qll

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2141,11 +2141,12 @@ private predicate isTypeExprBottomUp(Expr e) {
21412141
* Holds if `e` must be a type expression because it either occurs in a syntactic
21422142
* position where a type is expected, or it is part of a larger type expression.
21432143
*
2144-
* This predicate is only needed on snapshots for which type information is
2145-
* incomplete. It is an underapproximation; in cases where it is syntactically ambiguous
2146-
* whether an expression refers to a type or a value, we conservatively assume that
2147-
* it may be the latter and so this predicate does not consider the expression to be
2148-
* a type expression.
2144+
* This predicate is only needed on databases for which type information is
2145+
* incomplete - for example, when some dependencies could not be reached during
2146+
* extraction. It is an underapproximation; in cases where it is syntactically
2147+
* ambiguous whether an expression refers to a type or a value, we conservatively
2148+
* assume that it may be the latter and so this predicate does not consider the
2149+
* expression to be a type expression.
21492150
*/
21502151
pragma[nomagic]
21512152
private predicate isTypeExprTopDown(Expr e) {

0 commit comments

Comments
 (0)