Skip to content

[Breaking] Remove DualizableModel#210

Merged
blegat merged 2 commits intomasterfrom
bl/dualizablemodel
Mar 18, 2026
Merged

[Breaking] Remove DualizableModel#210
blegat merged 2 commits intomasterfrom
bl/dualizablemodel

Conversation

@blegat
Copy link
Copy Markdown
Member

@blegat blegat commented Mar 16, 2026

Testing whether it would work to just remove it

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.20%. Comparing base (c347f54) to head (2c2135a).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #210   +/-   ##
=======================================
  Coverage   94.20%   94.20%           
=======================================
  Files          14       14           
  Lines         742      742           
=======================================
  Hits          699      699           
  Misses         43       43           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joaquimg
Copy link
Copy Markdown
Member

the idea is that it would block certain cones, isn't it?
what is the alternative? let it error?

@blegat
Copy link
Copy Markdown
Member Author

blegat commented Mar 17, 2026

the idea is that it would block certain cones, isn't it?
what is the alternative? let it error?

If there is a MOI.Utilities.UniversalFallback then it will report that anything is supported anyway.
If a cone is not implementing MOI.dual_set, we already have supports_constraint return the right thing:

D = _dual_set_type(S)
if D === nothing
return false
end

function _dual_set_type(::Type{S}) where {S}
return try
MOI.dual_set_type(S)
catch
return nothing # The fallback of `dual_set_type` throws an error.
end
end

The advantage with that approach is that one can extend Dualization with new cones as well.

@blegat blegat force-pushed the bl/dualizablemodel branch from f4101cc to 2c2135a Compare March 17, 2026 20:22
@blegat blegat merged commit a1ec413 into master Mar 18, 2026
8 checks passed
@blegat blegat deleted the bl/dualizablemodel branch March 18, 2026 10:48
@blegat blegat changed the title Remove DualizableModel [Breaking] Remove DualizableModel Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants