Fix autograde for students with backslash in their ID#1881
Open
sydfromm wants to merge 3 commits intojupyter:mainfrom
Open
Fix autograde for students with backslash in their ID#1881sydfromm wants to merge 3 commits intojupyter:mainfrom
sydfromm wants to merge 3 commits intojupyter:mainfrom
Conversation
Contributor
|
|
Contributor
|
Thanks @sydfromm for this PR. I can't test it since I don't have such environment available (server with AD domain). Additionally, on my side the test passes with or without the modification in manage_submission.js. Can you provide a test that won't pass without the modification? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, using autograde on a student with a backslash in their student id raises an error. Backslashes were not encoded properly and appeared as forward slashes in the post request.
This pr aims to fix #912 by encoding the full api call.