feat: add new kep to provider cpuidle capability for besteffort QoS pod by hahahaheihei · Pull Request #5904 · kubernetes/enhancements

hahahaheihei · 2026-02-09T13:21:05Z

One-line PR description:
add new kep about enable cpu.idle for besteffort QoS pod

Issue link: provide cpu.idle capability for besteffort QoS level pod #5889

Other comments:

k8s-ci-robot · 2026-02-09T13:21:14Z

Welcome @hahahaheihei!

It looks like this is your first PR to kubernetes/enhancements 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/enhancements has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2026-02-09T13:21:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hahahaheihei
Once this PR has been reviewed and has the lgtm label, please assign dchen1107 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

keps/sig-node/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2026-02-09T13:21:15Z

Hi @hahahaheihei. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

hahahaheihei · 2026-02-10T02:40:11Z

@ffromani CC

ffromani · 2026-02-10T18:21:02Z

/ok-to-test

ffromani

initial review

ffromani · 2026-02-10T18:20:45Z

keps/sig-node/5889-cpuidle-for-besteffort-qos-pod/kep.yaml

+replaces: []
+
+# The target maturity stage in the current dev cycle for this KEP.
+stage: stable


should be "beta", this tracks the current feature maturity, which starts as beta

ffromani · 2026-02-10T18:23:00Z

keps/sig-node/5889-cpuidle-for-besteffort-qos-pod/README.md

+The feature require cgroupV2 & linux kernel 5.4 or later(cpu.idle enable)
+Users can configure the use of the CPU.idle function according to their needs or continue using cpu.shares/cpu.weight.
+
+The feature prototype code is ready. [code](https://github.com/kubernetes/kubernetes/pull/136458)


the KEP represent the design of the feature, so a PoC can help to better illustrate the design. However, the code is transitory (evolves and changes), while the design should be stable and fixed in time.
I don't think the PR helps too much here.

ffromani · 2026-02-10T18:24:07Z

keps/sig-node/5889-cpuidle-for-besteffort-qos-pod/README.md

+Safe Colocation: It allows safe colocation of BestEffort batch jobs with latency-sensitive services without the risk of performance degradation for the latter
+
+
+### Non-Goals


I guess non-goals are

change the cgroups weighting except the minimal changes required for this work

review QOS class handling in general

ffromani · 2026-02-10T18:25:15Z

keps/sig-node/5889-cpuidle-for-besteffort-qos-pod/README.md

+
+the new design , besteffort levels pod cpu.idle values set to 1 
+
+![](./new-qos.png)


how do we plan to implement the enable/disable toggle hinted in the "Proposal" above?

ffromani · 2026-02-10T18:25:42Z

keps/sig-node/5889-cpuidle-for-besteffort-qos-pod/README.md

+cat besteffort qos level cpu.idle value 
+0 mean the feature is disabled 
+1 mean the feature is enabled 


we need automated tests here

bleon-ethical · 2026-02-11T21:37:38Z

/retest

bleon-ethical · 2026-02-11T21:49:30Z

Thank you so much for contributing to Kubernetes, I'm gathering information to be able to help you better..

bleon-ethical · 2026-02-11T22:14:11Z

Hi @hahahaheihei, after reviewing the test failures (pull-enhancements-test and verify), here's what's needed for them to pass:

Fix the kep.yaml:

Change stage: stable to stage: beta (as suggested by @ffromani).

Make sure the latest-milestone field matches the current Kubernetes version.

Complete the PRR questionnaire:

In the README.md file, find the Production Readiness Review Questionnaire section.

You must answer all the questions (Enablement, Rollback, Monitoring, etc.). The tests are failing because the validator sees that these sections are empty or contain the default answers.

Update the Table of Contents:

Run make update-toc in your terminal and push the changes. This will fix the failure in the verify-toc.sh script.

Cleanup:

Remove the link to the prototype code from README.md, as the KEP should focus on the design, not a temporary implementation.

Thank you again for your help, have a great day.

bleon-ethical · 2026-02-11T22:14:54Z

/assign

AutuSnow · 2026-02-17T11:29:56Z

/cc

k8s-ci-robot · 2026-02-17T11:29:59Z

@AutuSnow: GitHub didn't allow me to request PR reviews from the following users: AutuSnow.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot · 2026-03-06T01:59:42Z

@hahahaheihei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-enhancements-test	`457c414`	link	true	`/test pull-enhancements-test`
pull-enhancements-verify	`457c414`	link	true	`/test pull-enhancements-verify`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

chzhj · 2026-03-09T05:56:36Z

@hahahaheihei Is there any update ？

hahahaheihei · 2026-03-09T06:23:25Z

@hahahaheihei Is there any update ？

The design remains unchanged, with only the document format and obvious errors modified.

chzhj · 2026-03-10T02:41:21Z

@hahahaheihei Is there any update ？

The design remains unchanged, with only the document format and obvious errors modified.

Hi @hahahaheihei @ffromani ,

Since this KEP missed the v1.36 release window, I would love to see how we can keep the momentum going.

Is it possible to target the upcoming v1.37 release?

ffromani · 2026-03-10T07:34:19Z

Is it possible to target the upcoming v1.37 release?

Yes, totally (note is too early to set the labels and we'd need a sig-node lead anyway)

feat: add new kep to provider cpuidle capability for besteffort QoS pod

0c5fcd7

k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Feb 9, 2026

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Feb 9, 2026

k8s-ci-robot requested review from dchen1107 and derekwaynecarr February 9, 2026 13:21

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 9, 2026

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2026

hahahaheihei mentioned this pull request Feb 10, 2026

provide cpu.idle capability for besteffort QoS level pod #5889

Open

4 tasks

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2026

ffromani reviewed Feb 10, 2026

View reviewed changes

k8s-ci-robot assigned bleon-ethical Feb 11, 2026

feat: add new test & fix kep stage version

457c414

		Safe Colocation: It allows safe colocation of BestEffort batch jobs with latency-sensitive services without the risk of performance degradation for the latter


		### Non-Goals


		the new design , besteffort levels pod cpu.idle values set to 1

		![](./new-qos.png)

Conversation

hahahaheihei commented Feb 9, 2026

Uh oh!

k8s-ci-robot commented Feb 9, 2026

Uh oh!

k8s-ci-robot commented Feb 9, 2026

Uh oh!

k8s-ci-robot commented Feb 9, 2026

Uh oh!

hahahaheihei commented Feb 10, 2026

Uh oh!

ffromani commented Feb 10, 2026

Uh oh!

ffromani left a comment

Choose a reason for hiding this comment

Uh oh!

ffromani Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

ffromani Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

ffromani Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

ffromani Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

ffromani Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

bleon-ethical commented Feb 11, 2026

Uh oh!

bleon-ethical commented Feb 11, 2026

Uh oh!

bleon-ethical commented Feb 11, 2026

Fix the kep.yaml:

Complete the PRR questionnaire:

Update the Table of Contents:

Cleanup:

Uh oh!

bleon-ethical commented Feb 11, 2026

Uh oh!

AutuSnow commented Feb 17, 2026

Uh oh!

k8s-ci-robot commented Feb 17, 2026

Uh oh!

k8s-ci-robot commented Mar 6, 2026

Uh oh!

chzhj commented Mar 9, 2026

Uh oh!

hahahaheihei commented Mar 9, 2026

Uh oh!

chzhj commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ffromani commented Mar 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chzhj commented Mar 10, 2026 •

edited

Loading