fix: align disabled Textarea text color with disabled Input#514
Open
msmx-mnakagawa wants to merge 1 commit intomasterfrom
Open
fix: align disabled Textarea text color with disabled Input#514msmx-mnakagawa wants to merge 1 commit intomasterfrom
msmx-mnakagawa wants to merge 1 commit intomasterfrom
Conversation
SLDS sets `color: inherit` for `.slds-textarea[disabled]` while `.slds-input[disabled]` gets an explicit muted color via `var(--slds-g-color-neutral-base-50)`. This causes disabled Textarea text to appear at full contrast, unlike disabled Input. Override the color using `registerStyle()` to match the Input behavior. This is a workaround for a suspected SLDS inconsistency. Remove if SLDS addresses it upstream. Closes #513 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
colorfor.slds-textarea[disabled]to match.slds-input[disabled]usingregisterStyle()color: inheritfor disabled Textarea while disabled Input getsvar(--slds-g-color-neutral-base-50, #444), causing inconsistent text colorCloses #513
🤖 Generated with Claude Code