Skip to content

Fix GithubReleaseV1 crash when commit includes discussion id#21869

Open
edvilme wants to merge 5 commits intomicrosoft:masterfrom
edvilme:fix-releasenotes-discussions
Open

Fix GithubReleaseV1 crash when commit includes discussion id#21869
edvilme wants to merge 5 commits intomicrosoft:masterfrom
edvilme:fix-releasenotes-discussions

Conversation

@edvilme
Copy link

@edvilme edvilme commented Feb 24, 2026

Context

Describe the context or motivation for this PR. Include links to any related Azure DevOps Work Items or GitHub issues.
📌 How to link to ADO Work Items
When running pipeline https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13386513&view=logs&j=739bb7ec-7296-5b40-7dff-ee3297bfdaa4&t=fd6eb289-d702-51fc-9ee6-4f19a6a112bf for releasing, one of the commits mentioned a GitHub Discussion item, which was not found by the tool, causing it to not generate release notes.


Task Name

Name of the updated or newly created pipeline task.
GithubReleaseV1


Description

Summarize the changes made in this PR clearly and concisely.
The issueOrPullRequest GraphQL return null for Discussion items, causing a TypeError when accessing .title or .state on null entries. Thus, crashing the step and not generating the release notes.

Added null guards to gracefully skip Discussion references instead of crashing.


Risk Assessment (Low / Medium / High)

Assess the level of risk and provide reasoning (e.g., scope, impact, backward compatibility).
Low, adds null checks


Change Behind Feature Flag (Yes / No)

Can this change be behind feature flag, if not why?
Yes


Tech Design / Approach

  • Design has been written and reviewed.
  • Any architectural decisions, trade-offs, and alternatives are captured.

Documentation Changes Required (Yes/No)

Indicate whether related documentation needs to be updated.

  • User guides, API specs, system diagrams, or runbooks are updated.

Mention that Github Discussions are not included.


Unit Tests Added or Updated (Yes / No)

Indicate whether unit tests were added or modified to reflect these changes.
N/A


Additional Testing Performed

List all other tests performed (manual or automated, including integration, regression, scenario tests, etc.).
N/A


Logging Added/Updated (Yes/No)

  • Appropriate log statements are added with meaningful messages.
  • Logging does not expose sensitive data.
  • Log levels are used correctly (e.g., info, warn, error).

N/A


Telemetry Added/Updated (Yes/No)

  • Custom telemetry (e.g., counters, timers, error tracking) is added as needed.
  • Events are tagged with proper metadata for filtering and analysis.
  • Telemetry is validated in staging or test environments.

N/A


Rollback Scenario and Process (Yes/No)

  • Rollback plan is documented.

N/A


Dependency Impact Assessed and Regression Tested (Yes/No)

  • All impacted internal modules, APIs, services, and third-party libraries are analyzed.
  • Results are reviewed and confirmed to not break existing functionality.

N/A


Checklist

  • Related issue linked (if applicable)
  • Task version was bumped — see versioning guide
  • Verified the task behaves as expected

The issueOrPullRequesr GraphQL return null for Discussion items, causing a TypeError when accessing .title or .state on null entries. Thus, crashing the step and not generating the release notes.

Added null guards to gracefully skip Discussion references instead of crashing.
@edvilme edvilme requested review from a team and manolerazvan as code owners February 24, 2026 21:28
@edvilme
Copy link
Author

edvilme commented Feb 24, 2026

Fixes #21870

@edvilme edvilme force-pushed the fix-releasenotes-discussions branch from 369a5e2 to b29a7ce Compare February 24, 2026 21:43
@edvilme
Copy link
Author

edvilme commented Mar 5, 2026

Related to #21112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant