Add Guardian suppression for BinSkim BA2001 warning on esbuild.exe#40
Open
ihuseynov-msft wants to merge 5 commits intomicrosoft:mainfrom
Open
Add Guardian suppression for BinSkim BA2001 warning on esbuild.exe#40ihuseynov-msft wants to merge 5 commits intomicrosoft:mainfrom
ihuseynov-msft wants to merge 5 commits intomicrosoft:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a Guardian suppression configuration to resolve a pipeline failure caused by BinSkim warning BA2001 on a third-party binary. The esbuild.exe binary from the npm package esbuild-windows-64 triggers an SDL security check that breaks the build under M365 policy enforcement. Since this is a bundled third-party build tool dependency that cannot be modified, a suppression entry is the appropriate solution.
Changes:
- Add
.gdn/.gdnsuppressconfiguration file with a suppression for BinSkim rule BA2001 on the esbuild-windows-64 binary
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a pipeline failure caused by Guardian’s SDL Post Analysis step.
BinSkim reported a BA2001 warning for:
node_modules/esbuild-windows-64/esbuild.exeHere https://dev.azure.com/skype/SCC/_build/results?buildId=74550001&view=logs&j=febc71de-dd9b-5d01-3b7a-dd4fa1386710&t=c8e71051-cae5-50e1-6f4d-c5cc05c8df6b
This binary comes from a third‑party npm dependency used during the build process and cannot be modified or removed. Under the enforced M365 policy, the warning breaks the build.
This PR adds a suppression entry in .gdn/.gdnsuppress to safely ignore this specific warning while keeping all other SDL checks active.
If you want, I can also generate a commit message or a TL;DR for the PR.
Provide your feedback on BizChatGenerate a commit messageProvide a TL;DR for the PRDrop your files here