Skip to content

Add Guardian suppression for BinSkim BA2001 warning on esbuild.exe#40

Open
ihuseynov-msft wants to merge 5 commits intomicrosoft:mainfrom
ihuseynov-msft:ihuseynov/guardian-task-fix
Open

Add Guardian suppression for BinSkim BA2001 warning on esbuild.exe#40
ihuseynov-msft wants to merge 5 commits intomicrosoft:mainfrom
ihuseynov-msft:ihuseynov/guardian-task-fix

Conversation

@ihuseynov-msft
Copy link
Member

This PR fixes a pipeline failure caused by Guardian’s SDL Post Analysis step.
BinSkim reported a BA2001 warning for:
node_modules/esbuild-windows-64/esbuild.exe

Here https://dev.azure.com/skype/SCC/_build/results?buildId=74550001&view=logs&j=febc71de-dd9b-5d01-3b7a-dd4fa1386710&t=c8e71051-cae5-50e1-6f4d-c5cc05c8df6b

This binary comes from a third‑party npm dependency used during the build process and cannot be modified or removed. Under the enforced M365 policy, the warning breaks the build.
This PR adds a suppression entry in .gdn/.gdnsuppress to safely ignore this specific warning while keeping all other SDL checks active.

If you want, I can also generate a commit message or a TL;DR for the PR.
Provide your feedback on BizChatGenerate a commit messageProvide a TL;DR for the PRDrop your files here

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Guardian suppression configuration to resolve a pipeline failure caused by BinSkim warning BA2001 on a third-party binary. The esbuild.exe binary from the npm package esbuild-windows-64 triggers an SDL security check that breaks the build under M365 policy enforcement. Since this is a bundled third-party build tool dependency that cannot be modified, a suppression entry is the appropriate solution.

Changes:

  • Add .gdn/.gdnsuppress configuration file with a suppression for BinSkim rule BA2001 on the esbuild-windows-64 binary

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants