Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Tightens the Microsoft.Testing.Platform MSBuild task behavior so a “successful” invocation that never actually communicated with the test application (no module info / no run summary) is treated as a failure, addressing silent no-test-run scenarios in dotnet test/VSTest mode (Fixes #6954).
Changes:
- Track whether a
RunSummaryInfoRequestwas received and fail the task if not. - Fail the task when no
ModuleInfoRequestwas received despite a successful tool exit. - Add new localized resource strings for the new failure messages.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs | Adds stricter post-run validation (module info + run summary must be received) before reporting success. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/MSBuildResources.resx | Adds new resource strings for missing module info / missing run summary failures. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.cs.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.de.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.es.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.fr.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.it.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.ja.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.ko.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.pl.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.pt-BR.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.ru.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.tr.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.zh-Hans.xlf | Localization entries for new resource strings. |
| src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/xlf/MSBuildResources.zh-Hant.xlf | Localization entries for new resource strings. |
src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform.MSBuild/Resources/MSBuildResources.resx
Show resolved
Hide resolved
...sting.Platform.MSBuild/buildMultiTargeting/Microsoft.Testing.Platform.MSBuild.VSTest.targets
Outdated
Show resolved
Hide resolved
src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Youssef1313
force-pushed
the
dev/ygerges/stricter-msbuild
branch
from
f890cac to
c601e32
Compare
Evangelink
reviewed
Mar 12, 2026
...sting.Platform.MSBuild/buildMultiTargeting/Microsoft.Testing.Platform.MSBuild.VSTest.targets
Outdated
Show resolved
Hide resolved
Comment on lines
+390
to
+399
| if (_moduleInfo is null) | ||
| { | ||
| Log.LogError(Resources.MSBuildResources.DidNotReceiveModuleInfo, TargetPath.ItemSpec.Trim()); | ||
| return false; | ||
| } | ||
| else if (!_receivedRunSummaryInfoRequest) | ||
| { | ||
| Log.LogError(Resources.MSBuildResources.DidNotReceiveRunSummaryInfo, TargetPath.ItemSpec.Trim()); | ||
| return false; | ||
| } |
Member
There was a problem hiding this comment.
Isn't this adding potentially confusing messages if the return value is false?
Member
Author
There was a problem hiding this comment.
Why do you think it's confusing messages?
…eting/Microsoft.Testing.Platform.MSBuild.VSTest.targets
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
You can also share your feedback on Copilot code review. Take the survey.
src/Platform/Microsoft.Testing.Platform.MSBuild/Tasks/InvokeTestingPlatformTask.cs
Outdated
Show resolved
Hide resolved
…stingPlatformTask.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated no new comments.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6954