Missing Redo state after Connection.workspace.applyEdit

[jmenzies12]

Hey there,

We are developing a VSCode extension that edits a TextDocument via the LanguageServer using Connection.workspace.applyEdit. Recently we ran into an issue when editing unopened documents, the original TextDocumentEdit works fine, undo also works fine, however there is no redo state to be triggered after the edit has been undone. This also happens if the TextDocument is open but not the active editor and then vscode is closed and reopened.

There is a redo state if the TextDocument is currently open (even if it is not currently the active editor).

Cheers
Jonathan

[dbaeumer]

@jrieken is this something that should be supported in VS Code?

[jmenzies12]

Let me know if you need any more information from my side

[dbaeumer]

@jrieken undo / redo should work with workspace edits.

[jrieken]

Yeah, it uses the undo/redo service to push operations but I am unsure how the editor/model works when it gets closed/disposed after editing