feat(plugin): implement install command and harden plugin resolution#33
Open
feat(plugin): implement install command and harden plugin resolution#33
Conversation
- Add install command with embedded plugin registry and package manager
detection (Homebrew, AUR via yay/paru)
- Scope PATH fallback to `omni-` prefixed binaries to prevent arbitrary
binary execution
- Add `${VAR}` env var expansion in manifest endpoint fields
- Add changeset for minor version bump
🦋 Changeset detectedLatest commit: fb072cd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…back - Add registry client that fetches plugin manifests from the remote plugin registry API (configurable via OMNI_PLUGIN_REGISTRY_URL) - Fall back to embedded registry when remote is unavailable - Add Serialize derives to manifest types for TOML round-tripping - Make install_plugin async to support remote fetch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the
omni installcommand and harden plugin resolution.omni-prefixed binaries (preventsomni foofrom executing arbitraryfooon PATH)${VAR}env var expansion in manifestendpointfieldsOMNI_PLUGIN_REGISTRY_URLenv varTest Steps
cargo test plugin-- all tests pass (36 plugin tests, 218 total)cargo clippy -- -D warnings-- cleanomni install beaconfetches manifest from registry (falls back to embedded if unreachable)omni pluginslists installed pluginsomni uninstall beaconremoves it