Array of const broken in 32bit, Stack issue in 64bit

[TetzkatLipHoka]

The recent update broke the Array of const support in 32bit in some way.

This script worked fine on my previous build (I think about 85 commits ago)

uses
  SysUtils;

var
  i, j : Integer;
begin
  Help3.Clear;  
  for j := 0 to Help1.Count-1 do
    begin
    for i := 0 to Help2.Count-1 do
      Help3.Add( Format( Help2[ i ], [ Trim( Help1[ j ] ), Trim( Help1[ j ] ) ] ) );    
    Help3.Add( '' );
    end;
end.

Now it crashes on 32bit with script exception when trying to call "format".
On 64bit Format works fine but accessing Help1 inline with j > 0 returns an empty string
Ex:
Help[x]=" OK"
0 : Format( 'Test%s', [ Help1[0] ] ) -> "Test OK"
1 : Format( 'Test%s', [ Help1[1] ] ) -> "Test"

Visualisation
Working

32bit, broken

[martijnlaan]

Thanks. Do you have a more complete example? Help1/2/3 are not defined, and Help1/2 initialization is also missing.

Also, which compiler is this and are you using InvokeCall.inc, or x86/64.inc?

BTW, you could try to use Git bisect to quickly isolate the commit which causes the problem.

[TetzkatLipHoka]

Ofc, whatever you need^^

I build using Delphi 10.3 Rio.
USEINVOKECALL is defined by

{$IFNDEF FPC}
...
  {$IFDEF DELPHI23UP}
  {$IFNDEF AUTOREFCOUNT}
  {$IFNDEF PS_USECLASSICINVOKE}
    {$DEFINE USEINVOKECALL}
  {$ENDIF}
  {$ENDIF}
  {$ENDIF}

in uPSRuntime

Help1-3 are SynEdits placed on Help-Forms as seen in the Screenshots.

While making the example I made some further tests ...
This would be the TStringList equivalent - this works as expected tho (32/64bit).

uses
  SysUtils;

var
  StrL1,
  StrL2,
  StrL3 : TStringList;

  i, j : Integer;
  S    : String;
begin
  StrL1 := TStringList.Create;
  StrL2 := TStringList.Create;
  StrL3 := TStringList.Create;
  
  StrL1.Add( 'Jane' );
  StrL1.Add( 'Amber' );
  StrL1.Add( 'Miku' );
  StrL1.Add( 'Sanae' );
  
  StrL2.Add( '%s likes pizza' );

  StrL3.Clear;
  for j := 0 to StrL1.Count-1 do
    begin
    for i := 0 to StrL2.Count-1 do
      StrL3.Add( Format( StrL2[ i ], [ Trim( StrL1[ j ] ), Trim( StrL1[ j ] ) ] ) );  
    end;    
    
  StrL1.free;
  StrL2.free;
  StrL3.free;    
end.

The Issue seems to be caused by access to the SynEdit.Lines by Stack access.
The SynEdit.Lines are registered for direct access like this:

  ...
  fPSScript                             := TPSScriptDebugger.Create( self );
  fPSScript.OnCompile                   := PSScriptCompile;
  fPSScript.OnExecute                   := PSScriptExecute;  
  ...

procedure TFrPascalScript.PSScriptCompile( Sender: TPSScript );
var
  i : Integer;
begin
  for i := Low( fHelpWindows ) to High( fHelpWindows ) do
    Sender.AddRegisteredVariable( 'Help' + IntToStr( i+1 ), 'TStrings' );
end;

procedure TFrPascalScript.PSScriptExecute( Sender: TPSScript );
var
  i : Integer;
begin
  for i := Low( fHelpWindows ) to High( fHelpWindows ) do
    fPSScript.SetVarToInstance( 'Help' + IntToStr( i+1 ), fHelpWindows[ i ].Edit.Lines );
end;

This works fine (32/64bit):

var
  S, S2 : String;
begin
...
  S := Help2[ i ];
  S2 := Trim( Help1[ j ] );  
  S := Format( S, [ S2, S2 ] );

while this causes the exception (on 32bit) or empty strings (if j > 0) (on 64bit):

var
  S, S2 : String;
begin
...
  S := Format( Help2[ i ], [ Trim( Help1[ j ] ), Trim( Help1[ j ] ) ] );

[martijnlaan]

Thanks.

• Does it happen when you use x86.inc/x64.inc instead of InvokeCall.inc by defining PS_USECLASSICINVOKE?
• Does it happen if you move the StrL1 etc to Delphi and use AddRegisteredVariable/SetVarToInstance for them? In other words, is using SynEdit really relevant?
• Can the example be reduced? It seems the for loops aren't relevant since your last example doesn't have any (but it also doesnt say what value i and j are)? Also it seems Help3 is irrelevant since the last example doesnt use it? In fact, can it be reduced to use only Help1 or only Help2? Or doesn it really need 2 lists to reproduce the issue? And are the Trim calls needed?
• Have you tried using git bisect? Just checkout the latest commit and then enter this on the command line: git bisect start bad. Then choose a commit in the past until you find one that works again and then enter git bisect good. It will then auto pick a commit in between for you to test and to enter either git bisect good or git bisect bad. This should quickly end at the commit introducing the issue. (Note: you can abort a bisect session by entering git bisect reset.)

Asking these things because the examples you posted so far don't allow me te produce your issue.

[TetzkatLipHoka]

• PS_USECLASSICINVOKE works fine for 32/64bit
• Global TStringLists with AddRegisteredVariable/SetVarToInstance also works fine on 32/64bit
• Loops are not required, calling format like this is sufficient:

    Help3.Add( Format( Help2[ 0 ], [ Trim( Help1[ 1 ] ), Trim( Help1[ 1 ] ) ] ) );

This will cause an exception on 32bit and return empty strings for Help1[ 1 ] on 64bit, Help1[ 0 ] works.

Iam not much into git mechanics, so no I didnt use bisect