From 9ae355c96e290463342ba7f6361d1a6b87275656 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:03:10 -0800 Subject: [PATCH 1/3] Fix typos: implicity -> implicitly, clonable -> cloneable; add typos config --- _typos.toml | 3 +++ src/ownership/codeowners_file_parser.rs | 2 +- src/ownership/mapper.rs | 4 ++-- tests/valid_project_test.rs | 6 +++--- 4 files changed, 9 insertions(+), 6 deletions(-) create mode 100644 _typos.toml diff --git a/_typos.toml b/_typos.toml new file mode 100644 index 0000000..be298fa --- /dev/null +++ b/_typos.toml @@ -0,0 +1,3 @@ +[default.extend-words] +# `fo` is used as a Rust closure parameter name (e.g., `|fo| fo.team`) +fo = "fo" diff --git a/src/ownership/codeowners_file_parser.rs b/src/ownership/codeowners_file_parser.rs index c40410c..2931e7e 100644 --- a/src/ownership/codeowners_file_parser.rs +++ b/src/ownership/codeowners_file_parser.rs @@ -95,7 +95,7 @@ fn build_codeowners_lines_in_priority(codeowners_file_path: String) -> Vec codeowners_file, Err(e) => { - // we can't return the error because it's not clonable + // we can't return the error because it's not cloneable eprintln!("Error reading codeowners file: {}", e); return vec![]; } diff --git a/src/ownership/mapper.rs b/src/ownership/mapper.rs index d04c4ee..867e620 100644 --- a/src/ownership/mapper.rs +++ b/src/ownership/mapper.rs @@ -48,7 +48,7 @@ impl Display for Source { Source::TeamGem => write!(f, "Owner specified in Team YML's `owned_gems`"), Source::TeamGlob(glob) => write!(f, "Owner specified in Team YML as an owned_glob `{}`", glob), Source::Package(package_path, glob) => { - write!(f, "Owner defined in `{}` with implicity owned glob: `{}`", package_path, glob) + write!(f, "Owner defined in `{}` with implicitly owned glob: `{}`", package_path, glob) } Source::TeamYml => write!(f, "Teams own their configuration files"), } @@ -208,7 +208,7 @@ mod tests { ); assert_eq!( Source::Package("packs/bam/packag.yml".to_string(), "packs/bam/**/**".to_string()).to_string(), - "Owner defined in `packs/bam/packag.yml` with implicity owned glob: `packs/bam/**/**`" + "Owner defined in `packs/bam/packag.yml` with implicitly owned glob: `packs/bam/**/**`" ); assert_eq!(Source::TeamYml.to_string(), "Teams own their configuration files"); } diff --git a/tests/valid_project_test.rs b/tests/valid_project_test.rs index ca2aa56..f207fac 100644 --- a/tests/valid_project_test.rs +++ b/tests/valid_project_test.rs @@ -241,7 +241,7 @@ fn test_for_file_same_team_multiple_ownerships() -> Result<(), Box> { Team YML: config/teams/payroll.yml Description: - Owner annotation at the top of the file - - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicity owned glob: `javascript/packages/PayrollFlow/**/**` + - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicitly owned glob: `javascript/packages/PayrollFlow/**/**` "})); Ok(()) } @@ -262,7 +262,7 @@ fn test_fast_for_file_same_team_multiple_ownerships() -> Result<(), Box Result<(), Box> { Team YML: config/teams/payroll.yml Description: - Owner annotation at the top of the file - - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicity owned glob: `javascript/packages/PayrollFlow/**/**` + - Owner defined in `javascript/packages/PayrollFlow/package.json` with implicitly owned glob: `javascript/packages/PayrollFlow/**/**` "})); Ok(()) From b1ac5904d14aeceb7f104b0d3316adfdfae93498 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:04:04 -0800 Subject: [PATCH 2/3] Fix grammatical issues in comments and documentation --- src/ownership/mapper/package_mapper.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ownership/mapper/package_mapper.rs b/src/ownership/mapper/package_mapper.rs index 2472e3f..1ab5d34 100644 --- a/src/ownership/mapper/package_mapper.rs +++ b/src/ownership/mapper/package_mapper.rs @@ -95,7 +95,7 @@ impl PackageMapper { let packages: Vec<&Package> = packages.iter().filter(|package| &package.package_type == package_type).collect(); // Nested packs can create a duplicate ownership false positive. - // We avoid it by treating nested packs as a single top level pack for the purpose of validations + // We avoid it by treating nested packs as a single top-level pack for the purposes of validation. let packages = remove_nested_packages(&packages); for package in packages { From 7b38deb69a57d32b2f8b11918ed6f9a9e03da706 Mon Sep 17 00:00:00 2001 From: Douglas Eichelberger Date: Thu, 5 Mar 2026 15:19:52 -0800 Subject: [PATCH 3/3] Remove _typos.toml --- _typos.toml | 3 --- 1 file changed, 3 deletions(-) delete mode 100644 _typos.toml diff --git a/_typos.toml b/_typos.toml deleted file mode 100644 index be298fa..0000000 --- a/_typos.toml +++ /dev/null @@ -1,3 +0,0 @@ -[default.extend-words] -# `fo` is used as a Rust closure parameter name (e.g., `|fo| fo.team`) -fo = "fo"