Upgraded to new version of python#2
Open
ErikKiss-FunnyFox wants to merge 4 commits intorefactor-into-subclassesfrom
Open
Upgraded to new version of python#2ErikKiss-FunnyFox wants to merge 4 commits intorefactor-into-subclassesfrom
ErikKiss-FunnyFox wants to merge 4 commits intorefactor-into-subclassesfrom
Conversation
Fixed lookup_table adjudicator to create data dir if it doesn't exist.
Fixed data file loading. Currently, QuantumAnnealing adjudicator doesn't work.
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the project to Python 3.12, adds new tests for the adjudicators, and fixes a bug in how the schedule file is loaded.
- Upgraded dependency versions and Python version in pyproject.toml
- Added tests in tests/test_adjudicators.py to validate adjudicators with a random game
- Updated file-loading logic in tangled_adjudicate/schrodinger/sparse_matrices.py and improved the lookup table setup to auto-create the data directory
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_adjudicators.py | Introduces tests to exercise the adjudicators using a random game scenario |
| tangled_adjudicate/schrodinger/sparse_matrices.py | Revises schedule file loading logic to use package resources, but misses a numpy import |
| tangled_adjudicate/adjudicators/lookup_table.py | Adjusts setup to create the data directory if it doesn’t exist |
| pyproject.toml | Updates the Python version and dependency versions for compatibility with Python 3.12 |
Files not reviewed (1)
- .bumpversion.cfg: Language not supported
Comments suppressed due to low confidence (1)
tangled_adjudicate/schrodinger/sparse_matrices.py:95
- Missing import for numpy; add 'import numpy as np' at the top of the file to support np.loadtxt.
data = np.loadtxt(file_path) # Import SR8 qubit information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded to python 3.12.
Added some testing.
Fixed a bug pertaining to loading file from package (new_schedule.txt) using module-based directory discovery.