GObject GSignal instance has no handler with id

[quozl]

On Raspberry Pi OS, the Write activity logs

/usr/lib/python3/dist-packages/gi/overrides/GObject.py:412: Warning: ../../../gobject/gsignal.c:2654: instance '0x23d09b0' has no handler with id '2370'
  GObjectModule.signal_handler_block(obj, handler_id)
/usr/lib/python3/dist-packages/gi/overrides/GObject.py:493: Warning: ../../../gobject/gsignal.c:2696: instance '0x23d09b0' has no handler with id '2370'
  return func(*args, **kwargs)

No impact.

This is related to checking if handler_id is connected before disconnect.

            abi.handler_block(self._abi_handler)
            try:
                logging.debug('Do abi %s' % do_abi_cb)
                do_abi_cb()
            finally:
                abi.handler_unblock(self._abi_handler)

we also need to store

self._connected_handlers = [self._abi_handler]

then disconnect if connected

def disconnect_signal(self):
        if self._abi_handler in self._connected_handlers:
            abi.disconnect(self._abi_handler)
            self._connected_handlers.remove(self._abi_handler)

I am unsure if i should generate pr.

[quozl]

The explanation seems reasonable. But I don't understand "unsure". What information do you need to make a pull request?

ok, will generate pr for review.

[Paroksh1]

Hi @quozl

The warning /gi/overrides/GObject.py: instance has no handler with id seems to be caused by attempting to block or unblock a signal handler that may already have been disconnected (or never connected).

To address this, I’ve implemented a fix that stores the handler ID in a _connected_handlers list at the time of connection. Before calling handler_block() or handler_unblock(), the code now checks whether the handler ID is still valid and connected. This ensures we avoid trying to operate on a non-existent handler and suppresses the warning.

While this approach was originally suggested by @drLite35, I’ve tested the logic and it aligns with the expected behavior based on how GObject manages signals.

If this direction looks good to you, I’d be happy to open a PR with the changes so you can review it in detail.

[jyotikhandekar]

Hello,

I am interested in working on this issue as my first contribution to Sugar Labs.
Before starting, I wanted to confirm if this issue is suitable for a beginner.

Thank you for your guidance.
Jyoti