add toArray api to access token#928
Open
hendeavors wants to merge 2 commits intothephpleague:masterfrom
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #928 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 191 194 +3
===========================================
Files 20 20
Lines 516 523 +7
===========================================
+ Hits 516 523 +7
|
hendeavors
force-pushed
the
arrayable-token
branch
from
56bcc1a to
1eccc08
Compare
ramsey
previously requested changes
Dec 22, 2021
Contributor
ramsey
left a comment
ramsey
left a comment
There was a problem hiding this comment.
This looks good to me. Please provide a test.
hendeavors
force-pushed
the
arrayable-token
branch
from
b83f33a to
c28e518
Compare
Contributor
Author
Test added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this allows some flexibility when working with values provided by the access token. Sometimes it is easier or necessary to pass an array of what the access token provides. I know jsonSerialize provides this already but it doesn't feel right to execute this method for the purposes of working with an array explicitly.
Added an additional interface to avoid a BC for the current release, although I think it would be proper to include the functionality in the next major release.