SetValue task no longer completes

[spudwebb]

There is an issue In the 4.0.0 version, the SetValue task no longer completes because an exception is raised in the callback when deserializing SetValueResult.remainingDuration. This property should be an object not a string.
This was introduced by this change: 56730df#diff-76c8632781a63f6963902465bb9685462ccc23c6bec8a7ad1b2e5e01ec5b30ba
Before this change the wrong object was deserialized to SetValueResult, so the problem did not show up.

I created a quick patch as I needed a fix ASAP
spudwebb@c7de77c

But I want to create a larger refactoring of all the commands methods, so that exceptions raised in the callbacks do not prevent the task to complete. I will create a PR when it's ready.

[marcus-j-davies]

Thanks @spudwebb

Im surprised it caused an exception - Im sure remainingDuration is of type Duration in Zwave JS, which is just a string?

(at least when I last checked 😅 )

[spudwebb]

The following is an example of a SetValue result that ZWaveJS.NET receives from the ZWave JS server:

{
	"type": "result",
	"success": true,
	"messageId": "fd566b4b-99f5-4fac-a67d-a63edd2d41ca",
	"result": {
		"result": {
			"status": 1,
			"remainingDuration": {
				"value": 3,
				"unit": "seconds"
			}
		}
	}
}

[marcus-j-davies]

Thanks, knee deep in another project currently, but over the weekend, I'll update the class SetValueResult to correct the type for remainingDuration Along with your patch, to guard against type issues.

public class SetValueResult
{
    internal SetValueResult() { }

    [Newtonsoft.Json.JsonProperty]
    public Enums.SetValueStatus status { get; internal set; }
    [Newtonsoft.Json.JsonProperty]
    public RemainingDuration remainingDuration { get; internal set; }
    [Newtonsoft.Json.JsonProperty]
    public string message { get; internal set; }
}


public class RemainingDuration
{
    internal RemainingDuration() { }

    [Newtonsoft.Json.JsonProperty]
    public decimal value { get; internal set; } /* Unsure what can be expected here currently */

    [Newtonsoft.Json.JsonProperty]
    public string unit { get; internal set; }
}