-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Agent tool binding — give Dev and QA agents access to workspace tools (#80) #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
87ded33
chore: create feature branch for #80
Abernaughty 63277c8
feat(events): add TOOL_CALL event type for agent tool usage tracking …
Abernaughty 38e32ad
feat(runner): add tools_config init, TOOL_CALL SSE events, tool usage…
Abernaughty 73f3312
feat(orchestrator): agent tool binding - bind_tools, tool loop, init_…
Abernaughty 2c8face
feat(orchestrator): full agent tool binding implementation (#80)
Abernaughty adc12f7
test(tool-binding): add 35 tests for agent tool binding (#80)
Abernaughty 5689745
chore: remove branch placeholder
Abernaughty 04c28c2
fix(test_e2e): convert node-level tests to async for developer_node/q…
Abernaughty 33969b9
placeholder
Abernaughty 5c7bac6
fix(orchestrator): sync node functions with _run_async bridge, fix sa…
Abernaughty 29ad3c4
temp placeholder for test_e2e
Abernaughty 9889eb7
fix(test_e2e): restore sync node calls — developer_node/qa_node are s…
Abernaughty 240c09b
fix(test_tool_binding): sync node tests, fix patch target src.tools.l…
Abernaughty ba4e2db
fix: address CodeRabbit review — 6 fixes for PR #83
Abernaughty b86c39a
fix(runner): per-pass dev tool call count (Fix 6)
Abernaughty 9ebf679
fix(tests): update test_tool_binding for Fixes 2/3/4/5
Abernaughty 3a372a7
fix(sandbox): format_validation_summary called with SandboxResult not…
Abernaughty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the dashboard SSE contract for
tool_call.This enum addition is still invisible to the browser:
dashboard/src/lib/types/api.ts(Lines 172-177) excludes'tool_call', anddashboard/src/lib/sse.ts(Lines 44-80 and 137-150) neither subscribes to nor dispatches it. The runner can publish the event, but the dashboard will drop it, so Issue#80's visibility goal stays broken. Based on learnings: Use SSE client with window event dispatch for real-time dashboard updates from backend.🤖 Prompt for AI Agents