Open
Conversation
MatloaItumeleng
requested review from
Zejnilovic,
benedeki,
dk1844,
lsulak and
yruslan
as code owners
JaCoCo code coverage report - scala 2.12.12
|
MatloaItumeleng
changed the title
ABLL526
previously approved these changes
Mar 31, 2026
Contributor
ABLL526
left a comment
ABLL526
left a comment
There was a problem hiding this comment.
LGTM, the only thing is the txt file. Can you remove the comments from it?
Other than that I will approve
Contributor
Author
|
The jmf-rules.txt file acts as a template for the project as part of Morana usage. The workflow will be updated to run coverage. For reference, see: https://github.com/MoranaApps/jacoco-method-filter/blob/master/jmf-rules.template.txt |
|
JaCoCo code coverage report - scala 2.12.12
No changed file in reports. |
TheLydonKing
approved these changes
Apr 2, 2026
TheLydonKing
left a comment
TheLydonKing
left a comment
There was a problem hiding this comment.
Just read the code, makes sense to me.
dk1844
approved these changes
Apr 2, 2026
| @@ -0,0 +1,155 @@ | |||
| # jacoco-method-filter — Default Rules & HowTo (Scala) | |||
MatloaItumeleng
commented
Apr 2, 2026
| jacocoReportName := s"spark-data-standardization Jacoco Report - scala:${scalaVersion.value}" | ||
| jacocoReportFormats := Set("html", "xml") | ||
|
|
||
| // jacocoExcludes := Seq("za/co/absa/standardization/udf/UDFBuilder*", "za/co/absa/standardization/udf/UDFNames") |
Contributor
Author
There was a problem hiding this comment.
Hi @miroslavpojer we also thinking about excluding some tests using the filter method please have a look for a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes:
closes #89