Skip to content

ITS: restore previous UPC iteration#15289

Open
f3sch wants to merge 4 commits intoAliceO2Group:devfrom
f3sch:its/pr1024
Open

ITS: restore previous UPC iteration#15289
f3sch wants to merge 4 commits intoAliceO2Group:devfrom
f3sch:its/pr1024

Conversation

@f3sch
Copy link
Copy Markdown
Collaborator

@f3sch f3sch commented Apr 19, 2026

I simplified some parameters into a single one (1:1). Also this correctly 'restores' how the UPC iteration is done.

Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch added 3 commits April 19, 2026 12:56
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
float timeTracklet{0.f}, timeSelection{0.f}, timeVertexing{0.f}, timeInit{0.f};
try {
for (int iteration = 0; iteration < std::min(mVertParams[0].nIterations, (int)mVertParams.size()); ++iteration) {
for (int iteration = 0; iteration < (int)mVertParams.size(); ++iteration) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the mVertParams.size is hardcoded to 2, this means that we will always run 2 iterations?
And since the actual job done by the 2nd iteration is triggered by nvertices(1st iteration) < vertPerRofThreshold, we have no way to disable it, even effectively? Do I miss something?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, by default there is only one iteration run, since the ITSVertexerParam.nIterations=1 by default, which triggers capping the mVertParams to only 1. In o2dpg for Pb-Pb we specficially set it nIterations=2.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 19, 2026

Error while checking build/O2/fullCI_slc9 for dd8f6fe at 2026-04-19 17:04:

## sw/BUILD/O2-full-system-test-latest/log
command /sw/slc9_x86-64/O2/slc9_x86-64-slc9_x86-64-local8/prodtests/full-system-test/dpl-workflow.sh had nonzero exit code 1


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/0972eb49c661c59fcddb1e8d6b1c661f5fe0d5c5/slc9_x86-64/o2checkcode/1.0-local685/etc/modulefiles
++ cat
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants