Making cypress log collector opt-in#4087
Conversation
…s are too verbose in the github workflow, and will pollute the output so much that it's difficult to read the gist of what actually happened.
📝 WalkthroughWalkthroughThe change adds environment variable loading via Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/e2e/support/index.ts`:
- Around line 62-63: Replace direct dotenv usage with Cypress.env to allow
CLI/CI/config values: remove the dotenv.config().parsed lookup and instead call
Cypress.env('CYPRESS_LOGS_COLLECTOR') (or assign to a local variable like const
cypressLogs = Cypress.env('CYPRESS_LOGS_COLLECTOR')) and use that value in the
existing conditional (e.g., check cypressLogs === 'true' or truthiness as
before). Update any references to env.CYPRESS_LOGS_COLLECTOR to use the new
variable so the support code picks up CLI/CI/Cypress-config values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 161b52d3-54fe-4faf-86e4-d3e3a9a76b7c
📒 Files selected for processing (1)
test/e2e/support/index.ts
Description
The cypress log collector is a bit too verbose for the github workflow, at least when we reach the end of the month and all tests are running serially in one runner instead of a 6-runner-matrix. Since the cypress cloud dashboard is unreachable at this point as well, it's very difficult to tell exactly which tests have failed (you'll have to parse through the plain logs).
Making the logs collector opt-in gives us simpler log output, while still making it easy to enable when running locally if you want it there.
Related Issue(s)
Verification/QA
kind/*andbackport*label to this PR for proper release notes groupingSummary by CodeRabbit