feat: update contact form to use npm package#698
feat: update contact form to use npm package#698sifterstudios wants to merge 11 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Hey, nice to have you here @sifterstudios! Deleting 11k lines of code is certainly one way to make an entrance 🔥 Is the source code of |
Hello, hello! 🔥🌪️
|
|
Update @rosvik - repo moved here: https://github.com/atb-AS/mrfylke-contact-form |
rosvik
left a comment
rosvik
left a comment
There was a problem hiding this comment.
Had a look through this now with @strandlie, and I think it makes sense overall 👍 A couple of questions:
- Theme and language doesn't seem to be synced between contact form and the main application. Could we use the same cookie for both?
- Comments 👇
| "@atb-as/config-specs": "^7.4.0", | ||
| "@atb-as/theme": "^15.0.1", | ||
| "@atb-as/utils": "^5.1.1", | ||
| "@emotion/is-prop-valid": "^1.4.0", |
| return Icon; | ||
| } | ||
|
|
||
| const iconSet: ContactFormConfig['icons'] = { |
There was a problem hiding this comment.
Why are icons passed in as configuration? Could contact-form take them directly from generate-assets instead?
2 participants
this PR transfers the contact-form from being embedded in planner-web to being imported from @mrfylke/contact-form. Has been tested locally, looks to have identical functionality.
Would appreciate some new eyes on this and advice on testing the submit call with e2e testing.