Skip to content

bass.h moved to c folder#1112

Merged
stonedDiscord merged 3 commits intomasterfrom
bass-linux-ci
Feb 2, 2026
Merged

bass.h moved to c folder#1112
stonedDiscord merged 3 commits intomasterfrom
bass-linux-ci

Conversation

@stonedDiscord
Copy link
Copy Markdown
Member

No description provided.

WisoAltred
WisoAltred previously approved these changes Feb 2, 2026
Copy link
Copy Markdown

@WisoAltred WisoAltred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is true

Copy link
Copy Markdown

@WisoAltred WisoAltred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now it is

@stonedDiscord stonedDiscord merged commit c92956d into master Feb 2, 2026
3 checks passed
@stonedDiscord stonedDiscord deleted the bass-linux-ci branch February 2, 2026 11:26
SyntaxNyah added a commit to SyntaxNyah/AO2-Client-DRO-VER. that referenced this pull request Mar 27, 2026
DRO servers only advertise a plain port (no ws_port/wss_port), so they
were assigned protocol="tcp" but the WebSocket connection rejected the
tcp:// URL scheme. This adds raw TCP transport via a new TcpConnection
class so DRO servers can be connected to directly.

- Add AOConnection abstract base class with shared signals/interface
- Add TcpConnection using QTcpSocket with AO packet buffering/parsing
- Refactor WebSocketConnection to inherit from AOConnection
- NetworkManager picks TcpConnection or WebSocketConnection by protocol
- Fix CMakeLists.txt include path for bass.h (moved to lib/bass/ in AttorneyOnline#1112)

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants