Fix incorrect index increment in SQL Server schema script parser#64
Open
prjanitor wants to merge 1 commit intoAvanade:mainfrom
Open
Fix incorrect index increment in SQL Server schema script parser#64prjanitor wants to merge 1 commit intoAvanade:mainfrom
prjanitor wants to merge 1 commit intoAvanade:mainfrom
Conversation
Changed 'i = +2' to 'i += 2' to properly skip past 'OR ALTER' tokens when parsing CREATE OR ALTER statements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The SQL Server schema script parser had a logic error where
i = +2was used instead ofi += 2when detecting 'OR ALTER' tokens in CREATE statements.Impact
This caused the parser to incorrectly set the index to
2instead of adding2to the current index, resulting in incorrect token parsing for statements like:Fix
Changed the assignment operator from
=to+=to properly increment the index by 2, skipping past the 'OR ALTER' tokens.Testing
The fix ensures that when parsing
CREATE OR ALTER TYPE/VIEW/PROCEDUREstatements, the parser correctly advances past the 'OR ALTER' tokens and properly extracts the object type and fully qualified name.This PR was generated by PRJanitor — an automated tool that finds and fixes small bugs in open-source projects.
We respect your contribution guidelines — if your project doesn't accept bot PRs, we won't send more. You can also add a
.github/prjanitor.ymlfile withenabled: falseto opt out explicitly.