Skip to content

[aks-preview] az aks create, nodepool add/update: Add option AzureContainerLinux to --os-sku parameter#9756

Open
aadhar-agarwal wants to merge 1 commit intoAzure:mainfrom
aadhar-agarwal:aadagarwal/acl-enum-aks-preview
Open

[aks-preview] az aks create, nodepool add/update: Add option AzureContainerLinux to --os-sku parameter#9756
aadhar-agarwal wants to merge 1 commit intoAzure:mainfrom
aadhar-agarwal:aadagarwal/acl-enum-aks-preview

Conversation

@aadhar-agarwal
Copy link
Copy Markdown

@aadhar-agarwal aadhar-agarwal commented Apr 2, 2026

Add option AzureContainerLinux to --os-sku option for az aks create, az aks nodepool add, and az aks nodepool update.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create
az aks nodepool add
az aks nodepool update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Validation for Breaking Change Starting...

Thanks for your contribution!

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 2, 2026

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

@aadhar-agarwal aadhar-agarwal changed the title [AKS] Add option AzureContainerLinux to --os-sku for az aks nodepool add and az aks nodepool update [aks-preview] az aks nodepool add/update: Add option AzureContainerLinux to --os-sku parameter Apr 2, 2026
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-enum-aks-preview branch from 49105cd to d3893d9 Compare April 2, 2026 23:47
@aadhar-agarwal aadhar-agarwal marked this pull request as ready for review April 2, 2026 23:57
Copilot AI review requested due to automatic review settings April 2, 2026 23:57
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the aks-preview extension to recognize AzureContainerLinux as a valid value for the --os-sku parameter, and bumps the extension version to publish the change.

Changes:

  • Add AzureContainerLinux OS SKU constant and include it in the allowed --os-sku enums.
  • Update command help text to document the new OS SKU option.
  • Add a scenario test validating az aks nodepool add --os-sku AzureContainerLinux.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/aks-preview/setup.py Bumps extension version to 19.0.0b30.
src/aks-preview/HISTORY.rst Adds changelog entry for the new --os-sku option.
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Adds scenario test for nodepool add with AzureContainerLinux.
src/aks-preview/azext_aks_preview/_params.py Extends --os-sku allowed values to include AzureContainerLinux (create/add/update enums).
src/aks-preview/azext_aks_preview/_help.py Updates --os-sku help text to list AzureContainerLinux.
src/aks-preview/azext_aks_preview/_consts.py Introduces CONST_OS_SKU_AZURECONTAINERLINUX.

@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-enum-aks-preview branch from d3893d9 to 78a2299 Compare April 3, 2026 00:24
@aadhar-agarwal aadhar-agarwal changed the title [aks-preview] az aks nodepool add/update: Add option AzureContainerLinux to --os-sku parameter [aks-preview] az aks create/nodepool add/update: Add option AzureContainerLinux to --os-sku parameter Apr 3, 2026
@aadhar-agarwal aadhar-agarwal changed the title [aks-preview] az aks create/nodepool add/update: Add option AzureContainerLinux to --os-sku parameter [aks-preview] az aks create, nodepool add/update: Add option AzureContainerLinux to --os-sku parameter Apr 3, 2026
@aadhar-agarwal aadhar-agarwal force-pushed the aadagarwal/acl-enum-aks-preview branch from 78a2299 to 011c9c2 Compare April 3, 2026 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants