[aks-preview] az aks create, nodepool add/update: Add option AzureContainerLinux to --os-sku parameter#9756
Conversation
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
az aks nodepool add/update: Add option AzureContainerLinux to --os-sku parameter
49105cd to
d3893d9
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the aks-preview extension to recognize AzureContainerLinux as a valid value for the --os-sku parameter, and bumps the extension version to publish the change.
Changes:
- Add
AzureContainerLinuxOS SKU constant and include it in the allowed--os-skuenums. - Update command help text to document the new OS SKU option.
- Add a scenario test validating
az aks nodepool add --os-sku AzureContainerLinux.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/aks-preview/setup.py | Bumps extension version to 19.0.0b30. |
| src/aks-preview/HISTORY.rst | Adds changelog entry for the new --os-sku option. |
| src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py | Adds scenario test for nodepool add with AzureContainerLinux. |
| src/aks-preview/azext_aks_preview/_params.py | Extends --os-sku allowed values to include AzureContainerLinux (create/add/update enums). |
| src/aks-preview/azext_aks_preview/_help.py | Updates --os-sku help text to list AzureContainerLinux. |
| src/aks-preview/azext_aks_preview/_consts.py | Introduces CONST_OS_SKU_AZURECONTAINERLINUX. |
d3893d9 to
78a2299
Compare
az aks nodepool add/update: Add option AzureContainerLinux to --os-sku parameter78a2299 to
011c9c2
Compare
Add option AzureContainerLinux to --os-sku option for
az aks create,az aks nodepool add, andaz aks nodepool update.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks createaz aks nodepool addaz aks nodepool updateGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.