fix: write dependency-reduced-pom.xml to target/ to prevent incremental build issues#860
Open
ahmedmuhsin wants to merge 1 commit intoAzure:devfrom
Open
fix: write dependency-reduced-pom.xml to target/ to prevent incremental build issues#860ahmedmuhsin wants to merge 1 commit intoAzure:devfrom
ahmedmuhsin wants to merge 1 commit intoAzure:devfrom
Conversation
…al build issues The maven-shade-plugin writes dependency-reduced-pom.xml to the project root by default. On subsequent builds without clean, Maven reads this file instead of pom.xml, loses protobuf/gRPC dependencies, and produces a JAR without StreamingMessage and other generated gRPC classes. Setting dependencyReducedPomLocation to target/ ensures clean deletes it and incremental builds always use the real pom.xml.
ahmedmuhsin
requested review from
TsuyoshiUshio,
gavin-aguiar,
hallvictoria,
swapnil-nagar and
vrdmr
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The maven-shade-plugin writes dependency-reduced-pom.xml to the project root by default. On subsequent builds without clean, Maven reads this file instead of pom.xml, loses protobuf/gRPC dependencies, and produces a JAR without StreamingMessage and other generated gRPC classes.
What changed
Impact