Remove leaf_customer_span_id baggage re-parenting hack from tracing#46085
Open
needuv wants to merge 2 commits intoagentserver/invoke-reponsesfrom
Open
Remove leaf_customer_span_id baggage re-parenting hack from tracing#46085needuv wants to merge 2 commits intoagentserver/invoke-reponsesfrom
needuv wants to merge 2 commits intoagentserver/invoke-reponsesfrom
Conversation
Use standard OTel traceparent propagation instead of overriding the parent span ID via the baggage header's leaf_customer_span_id key. - Remove _parse_baggage_key() and _override_parent_span_id() helpers - Remove baggage_header parameter from span/start_span/_extract_context - Simplify _prepare_request_span_args to return 3-tuple (no baggage) - Remove associated tests (TestParseBaggageKey, test_baggage_leaf_customer_span_id) - Preserve set_baggage/detach_baggage OTel context API (unrelated) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use standard OTel traceparent propagation instead of overriding the parent span ID via the baggage header's leaf_customer_span_id key.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines