Draft
Conversation
github-actions
bot
added
the
Evaluation
slister1001
force-pushed
the
fix/redteam-errored-count-tracking
branch
from
16055c4 to
bc36e7c
Compare
Previously, objectives that failed during attack execution or risk categories with zero prepared objectives were silently dropped from the pipeline. The result_counts.errored field always showed 0 because _compute_result_count only counted existing output items. Changes: - _execution_manager.py: Record 0-objective categories as failed in red_team_info instead of silently skipping. Add expected_count to all red_team_info entries to track expected vs actual objectives. - _result_processor.py: Add _extract_expected_total() to compute total expected objectives from red_team_info (de-duplicated by risk category). Pass expected_total to _compute_result_count() which now computes errored as the delta between expected and actual items. Add partial_failure to _determine_run_status failure detection. - test_result_processor_errored.py: 31 new unit tests covering _compute_result_count with expected_total, _extract_expected_total de-duplication logic, and _determine_run_status failure detection. - test_foundry.py: 3 new tests for 0-objective recording and expected_count propagation in FoundryExecutionManager. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
slister1001
force-pushed
the
fix/redteam-errored-count-tracking
branch
from
bc36e7c to
992ddd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines