[Storage] Removed unused keywords and updated aiohttp dependency#46094
Open
weirongw23-msft wants to merge 2 commits intoAzure:mainfrom
Open
[Storage] Removed unused keywords and updated aiohttp dependency#46094weirongw23-msft wants to merge 2 commits intoAzure:mainfrom
aiohttp dependency#46094weirongw23-msft wants to merge 2 commits intoAzure:mainfrom
Conversation
…tainer_metadata, delete_container
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to simplify the Storage Blob ContainerClient API surface by removing some advertised keyword parameters from the sync/async container APIs’ documentation/type stubs, and to update Storage packages’ dev dependency floor for aiohttp.
Changes:
- Updated multiple
sdk/storage/*/dev_requirements.txtfiles to requireaiohttp>=3.13.5. - Removed
etag/match_condition(and forset_container_metadata,if_unmodified_since) fromContainerClienttype stubs (.pyi) for selected methods. - Removed the corresponding keyword documentation from
ContainerClientdocstrings for selected sync/async methods.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/storage/azure-storage-queue/dev_requirements.txt | Raise minimum aiohttp version for dev dependencies. |
| sdk/storage/azure-storage-file-share/dev_requirements.txt | Raise minimum aiohttp version for dev dependencies. |
| sdk/storage/azure-storage-file-datalake/dev_requirements.txt | Raise minimum aiohttp version for dev dependencies. |
| sdk/storage/azure-storage-blob/dev_requirements.txt | Raise minimum aiohttp version for dev dependencies. |
| sdk/storage/azure-storage-blob-changefeed/dev_requirements.txt | Raise minimum aiohttp version for dev dependencies. |
| sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py | Remove keyword docs from sync ContainerClient docstrings. |
| sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.pyi | Remove keyword parameters from sync ContainerClient stub signatures. |
| sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.py | Remove keyword docs from async ContainerClient docstrings. |
| sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.pyi | Remove keyword parameters from async ContainerClient stub signatures. |
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.py
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.pyi
Show resolved
Hide resolved
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.pyi
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
ContainerClient'sset_container_metadata,acquire_lease, anddelete_containerAPIs.aiohttpversion to be at least 3.13.5, the most recent stable version, indev_requirements.txt.Please note that
set_container_metadataasync version was already typed / documented properly, which is why there's no change.