Skip to content

[Storage] Removed unused keywords and updated aiohttp dependency#46094

Open
weirongw23-msft wants to merge 2 commits intoAzure:mainfrom
weirongw23-msft:weirongw23/remove-keywords
Open

[Storage] Removed unused keywords and updated aiohttp dependency#46094
weirongw23-msft wants to merge 2 commits intoAzure:mainfrom
weirongw23-msft:weirongw23/remove-keywords

Conversation

@weirongw23-msft
Copy link
Copy Markdown
Member

This PR addresses two issues:

  1. Removed unnecessary keywords and docs from ContainerClient's set_container_metadata, acquire_lease, and delete_container APIs.
  2. Updated aiohttp version to be at least 3.13.5, the most recent stable version, in dev_requirements.txt.

Please note that set_container_metadata async version was already typed / documented properly, which is why there's no change.

@weirongw23-msft weirongw23-msft marked this pull request as ready for review April 2, 2026 21:41
Copilot AI review requested due to automatic review settings April 2, 2026 21:41
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Apr 2, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to simplify the Storage Blob ContainerClient API surface by removing some advertised keyword parameters from the sync/async container APIs’ documentation/type stubs, and to update Storage packages’ dev dependency floor for aiohttp.

Changes:

  • Updated multiple sdk/storage/*/dev_requirements.txt files to require aiohttp>=3.13.5.
  • Removed etag / match_condition (and for set_container_metadata, if_unmodified_since) from ContainerClient type stubs (.pyi) for selected methods.
  • Removed the corresponding keyword documentation from ContainerClient docstrings for selected sync/async methods.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
sdk/storage/azure-storage-queue/dev_requirements.txt Raise minimum aiohttp version for dev dependencies.
sdk/storage/azure-storage-file-share/dev_requirements.txt Raise minimum aiohttp version for dev dependencies.
sdk/storage/azure-storage-file-datalake/dev_requirements.txt Raise minimum aiohttp version for dev dependencies.
sdk/storage/azure-storage-blob/dev_requirements.txt Raise minimum aiohttp version for dev dependencies.
sdk/storage/azure-storage-blob-changefeed/dev_requirements.txt Raise minimum aiohttp version for dev dependencies.
sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.py Remove keyword docs from sync ContainerClient docstrings.
sdk/storage/azure-storage-blob/azure/storage/blob/_container_client.pyi Remove keyword parameters from sync ContainerClient stub signatures.
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.py Remove keyword docs from async ContainerClient docstrings.
sdk/storage/azure-storage-blob/azure/storage/blob/aio/_container_client_async.pyi Remove keyword parameters from async ContainerClient stub signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants