Open
Conversation
2a86ec9 to
621a8a7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Copilot SDK adapter to use specific Copilot SDK import paths for tool discovery and permission/config types.
Changes:
- Switch
Toolimport tofrom copilot.tools import Toolin tool discovery. - Switch
PermissionRequestResult/ProviderConfigimports tofrom copilot.session import ...and remove the runtime fallback behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sdk/agentserver/azure-ai-agentserver-githubcopilot/azure/ai/agentserver/githubcopilot/_tool_discovery.py | Uses a single Copilot SDK import path for Tool. |
| sdk/agentserver/azure-ai-agentserver-githubcopilot/azure/ai/agentserver/githubcopilot/_copilot_adapter.py | Uses a single Copilot SDK import path for permission/config types and removes fallback object construction. |
...ver/azure-ai-agentserver-githubcopilot/azure/ai/agentserver/githubcopilot/_tool_discovery.py
Show resolved
Hide resolved
...er/azure-ai-agentserver-githubcopilot/azure/ai/agentserver/githubcopilot/_copilot_adapter.py
Show resolved
Hide resolved
...er/azure-ai-agentserver-githubcopilot/azure/ai/agentserver/githubcopilot/_copilot_adapter.py
Show resolved
Hide resolved
...ver/azure-ai-agentserver-githubcopilot/azure/ai/agentserver/githubcopilot/_tool_discovery.py
Show resolved
Hide resolved
jodeklotzms
approved these changes
Apr 3, 2026
Member
jodeklotzms
left a comment
There was a problem hiding this comment.
I'm good with this. I assume you've tested this more than I have!
Member
|
The change looks straightfoward to me, but here's my context agent's review: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines