Skip to content

Re-enable WebSocket invalid-server test (fixes #131) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bghgary merged 3 commits into from
Apr 17, 2026
Merged

Re-enable WebSocket invalid-server test (fixes #131) #162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c098b82
Re-enable WebSocket invalid-server test
bghgary Apr 17, 2026
bf297d6
Address review: use onclose as terminal event and example.invalid domain
bghgary Apr 17, 2026
4a1393f
Revert domain to UUID .com (Win32_x86_Chakra times out on .invalid)
bghgary Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 19 additions & 7 deletions Tests/UnitTests/Scripts/tests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,13 +526,25 @@ if (hostPlatform !== "Unix") {
};
});

// TODO: This is not working reliably: see https://github.com/BabylonJS/JsRuntimeHost/issues/131
// it("should trigger error callback with invalid server", function (done) {
// const ws = new WebSocket("wss://caddddfd-ee88-4771-b293-8a8e13b330ee.com");
// ws.onerror = () => {
// done();
// };
// });
it("should trigger error callback with invalid server", function (done) {
this.timeout(10000);
// Random UUID-based hostname so the domain is guaranteed unregistered
// (RFC-reserved `.invalid` causes a >10s DNS path on Win32 x86 Chakra).
const ws = new WebSocket("wss://caddddfd-ee88-4771-b293-8a8e13b330ee.com");
let errorFired = false;
ws.onerror = () => {
errorFired = true;
};
ws.onclose = () => {
try {
expect(errorFired).to.be.true;
done();
}
catch (e) {
done(e);
}
};
});

it("should trigger error callback with invalid domain", function (done) {
this.timeout(10000);
Expand Down
Loading