Closed
Conversation
Contributor
AntoineReneleau
commented
Jun 24, 2015
- Multiapp capatibility gatekeeper#1
- Update uri.js version to 1.15.2 to remove jQuery dep and useless main js angular-uri#1
app/scripts/controllers/auth.js
Outdated
There was a problem hiding this comment.
Y'a peut être meux à faire que du console.log ?
Member
|
@AntoineReneleau tu penses que certaines parties sont testables ? |
Contributor
Author
|
Je vais déjà faire les corrections, mettre en place l'OAuth multiapp et je me mettrai sur les tests après. 😄 |
72be431 to
a31c2f3
Compare
app/scripts/services/authManager.js
Outdated
490e74d to
f537ceb
Compare
5cae5f9 to
7102c4f
Compare
Member
|
Left for #20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.