Skip to content

feat(sdk-core): add webauthnInfo support to bulkAcceptShare#8365

Draft
derranW26 wants to merge 1 commit intomasterfrom
WP-8314-bulk-accept-webauthn-info
Draft

feat(sdk-core): add webauthnInfo support to bulkAcceptShare#8365
derranW26 wants to merge 1 commit intomasterfrom
WP-8314-bulk-accept-webauthn-info

Conversation

@derranW26
Copy link
Copy Markdown

Summary

  • Adds AcceptShareWebauthnInfo type and extends BulkAcceptShareOptions and AcceptShareOptionsRequest with optional webauthnInfo
  • In both ECDH and userMultiKeyRotationRequired branches of bulkAcceptShare(), encrypts wallet prv with PRF-derived passphrase when webauthnInfo is provided
  • Passphrase is consumed client-side only — never sent to server

Test plan

  • ECDH branch with webauthnInfo: verifies otpDeviceId, prfSalt, encryptedPrv present; passphrase absent
  • userMultiKeyRotationRequired branch with webauthnInfo: same assertions + pub still present
  • Backward compat: no webauthnInfo field when not provided
  • All 13 existing bulkAcceptShare tests still pass
  • tsc --noEmit passes

Ticket: WP-8314

When webauthnInfo is provided, each share entry now includes a second
encrypted copy of the wallet private key using the PRF-derived passphrase,
alongside the standard password-encrypted copy. The passphrase is consumed
client-side only and never sent to the server.

Ticket: WP-8314
@derranW26 derranW26 force-pushed the WP-8314-bulk-accept-webauthn-info branch from 0d54fd1 to ada11fd Compare March 27, 2026 17:51
Copy link
Copy Markdown
Contributor

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants