Add `pub` and `use` keywords and parse them by LesterEvSe · Pull Request #256 · BlockstreamResearch/SimplicityHL

LesterEvSe · 2026-03-26T16:18:14Z

This PR introduces the baseline architecture for dependency and import resolution. As part of the larger module system roadmap, this is a scoped implementation focused strictly on parsing use statements and visibility.

KyrylR · 2026-03-26T16:42:04Z

src/lexer.rs

 pub type Spanned<T> = (T, SimpleSpan);
 pub type Tokens<'src> = Vec<(Token<'src>, crate::error::Span)>;

+/// # Architecture Note: Omitted Keywords


Why this is needed?

It explains why the compiler does not need the super and crate keywords at all.

KyrylR · 2026-03-26T16:42:20Z

src/parse.rs

    TypeAlias(TypeAlias),
    /// A function.
    Function(Function),
+    /// Use keyword to load other items


What other items means?

KyrylR · 2026-03-26T16:43:06Z

src/parse.rs

+/// Definition of a declaration
+#[derive(Clone, Debug)]
+#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
+pub struct UseDecl {
+    visibility: Visibility,
+    path: Vec<Identifier>,
+    items: UseItems,
+    span: Span,
+}
+
+impl UseDecl {
+    /// Access the visibility of the use declaration.
+    pub fn visibility(&self) -> &Visibility {
+        &self.visibility
+    }
+
+    /// Access the visibility of the function.
+    pub fn path(&self) -> &Vec<Identifier> {
+        &self.path
+    }
+
+    /// Access the visibility of the function.
+    pub fn items(&self) -> &UseItems {
+        &self.items
+    }
+
+    /// Access the span of the use declaration.
+    pub fn span(&self) -> &Span {
+        &self.span
+    }
+}


Let's not add docs for self-explanatory fns

KyrylR · 2026-03-26T16:43:14Z

src/parse.rs

+}
+
 impl Function {
+    /// Access the visibility of the function.


KyrylR · 2026-03-26T17:20:25Z

src/ast.rs

            parse::Item::Function(function) => {
                Function::analyze(function, ty, scope).map(Self::Function)
            }
+            parse::Item::Use(_) => todo!(),


Let's do the reject gracefully, just in case

KyrylR · 2026-03-26T17:20:58Z

src/parse.rs

Visibility is doped here

Same for type aliases

KyrylR · 2026-03-27T12:14:16Z

src/parse.rs

+#[derive(Clone, Debug)]
+#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
+pub struct UseDecl {
+    visibility: Visibility,
+    path: Vec<Identifier>,
+    items: UseItems,
+    span: Span,
+}


Could you add a rust doc explaining what is an intention for those fields?

KyrylR · 2026-03-27T12:14:25Z

src/parse.rs

+
+#[derive(Clone, Debug, PartialEq, Eq, Hash)]
+#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
+pub enum UseItems {
+    Single(Identifier),
+    List(Vec<Identifier>),
+}


KyrylR · 2026-03-27T12:15:09Z

src/parse.rs

+#[derive(Clone, Debug, PartialEq, Eq, Hash, Default)]
+#[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
+pub enum Visibility {
+    Public,
+    #[default]
+    Private,
+}


Could you move this above UseDecl?

KyrylR · 2026-03-27T12:31:22Z

Pls add description

KyrylR · 2026-03-27T12:31:30Z

Why lexer::is_keyword() was not updated?

KyrylR · 2026-03-27T12:39:30Z

Why use bar; is not allowed? But with arbitrary it is allowed...

LesterEvSe · 2026-03-27T15:20:14Z

Why use bar; is not allowed? But with arbitrary it is allowed...

I have updated this code to require at least three path segments. This is necessary because we cannot load specific functionality without at least three items in the path. The first is the alias, the second is the specific file, and the third is the specific function or item being imported.

This logic enforced in the following segment of parse.rs (impl ChumskyParser for UseDecl)

let path = Identifier::parser()
    .then_ignore(just(Token::DoubleColon))
    .repeated()
    .at_least(2)
    .collect::<Vec<_>>();

KyrylR

ACK 0f853eb

It is a good start, though it is not merged into master, so I won't use the merge script

LesterEvSe requested a review from KyrylR March 26, 2026 16:18

LesterEvSe self-assigned this Mar 26, 2026

LesterEvSe requested a review from delta1 as a code owner March 26, 2026 16:18

LesterEvSe added the enhancement New feature or request label Mar 26, 2026

KyrylR reviewed Mar 26, 2026

View reviewed changes

src/parse.rs Outdated

}

impl Function {

/// Access the visibility of the function.

Copy link
Copy Markdown

Collaborator

KyrylR Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

KyrylR reviewed Mar 26, 2026

View reviewed changes

LesterEvSe force-pushed the feature/parse-use-pub-keywords branch from e378410 to 5bcf426 Compare March 27, 2026 10:07

LesterEvSe requested a review from KyrylR March 27, 2026 10:07

LesterEvSe force-pushed the feature/parse-use-pub-keywords branch from 5bcf426 to 4c8ee5e Compare March 27, 2026 12:09

KyrylR reviewed Mar 27, 2026

View reviewed changes

LesterEvSe force-pushed the feature/parse-use-pub-keywords branch 2 times, most recently from 577e0a7 to 2328407 Compare March 27, 2026 12:29

LesterEvSe requested a review from KyrylR March 27, 2026 12:29

LesterEvSe force-pushed the feature/parse-use-pub-keywords branch from 2328407 to 0656bb2 Compare March 27, 2026 15:18

LesterEvSe force-pushed the feature/parse-use-pub-keywords branch from 0656bb2 to 5fcfb76 Compare March 27, 2026 15:54

feat: add pub and use keywords and parse them

0f853eb

LesterEvSe force-pushed the feature/parse-use-pub-keywords branch from 5fcfb76 to 0f853eb Compare March 27, 2026 16:08

KyrylR approved these changes Mar 27, 2026

View reviewed changes

KyrylR merged commit 0f853eb into BlockstreamResearch:dev/imports Mar 27, 2026
11 checks passed

Conversation

LesterEvSe commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

KyrylR commented Mar 27, 2026

Uh oh!

KyrylR commented Mar 27, 2026

Uh oh!

KyrylR commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LesterEvSe commented Mar 27, 2026

Uh oh!

KyrylR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LesterEvSe commented Mar 26, 2026 •

edited

Loading

KyrylR commented Mar 27, 2026 •

edited

Loading