fix: utf-16 rendering for multiline errors#257
Open
gerau wants to merge 4 commits intoBlockstreamResearch:masterfrom
Open
fix: utf-16 rendering for multiline errors#257gerau wants to merge 4 commits intoBlockstreamResearch:masterfrom
gerau wants to merge 4 commits intoBlockstreamResearch:masterfrom
Conversation
gerau
force-pushed
the
simc/utf16-fix
branch
2 times, most recently
from
51e6042 to
009ddc4
Compare
Contributor
|
In e26797b: what is going on with this commit? This doesn't compile. |
metalurgical
added a commit
to metalurgical/SimplicityHL
that referenced
this pull request
Mar 30, 2026
Previously, newline detection operated per character, causing CRLF to be treated as two separate newlines. This resulted in incorrect line numbers, extra blank lines, and misaligned error spans on Windows inputs. This change introduces CRLF-aware newline parsing while preserving support for LF, CR, and Unicode newline characters. Also fixes: - incorrect line/column calculation for multi-line spans - UTF-16 column alignment for multi-byte characters - off-by-one error in multiline underline rendering - zero-length spans not displaying a caret Error rendering is now consistent across platforms and input encodings. Merge after PR BlockstreamResearch#257
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes multiline display in case if first line of
Erroris contains UTF-16 symbol.Also removes
println!()statement in test and revert check for newline inget_line_colto == '\n', becausechumsky::is_newlineis introducing CRLF regression.