Identifier str conversions#259
Closed
LesterEvSe wants to merge 1 commit intoBlockstreamResearch:masterfrom
Closed
Conversation
Contributor
|
I am not sure if that is even needed, because the same implementations already exist in the
|
Collaborator
Author
|
Okay, I have checked the architecture again and these changes can be removed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It allows us to easily and ergonomically convert Identifiers to and from standard &str slices across the codebase without having to manually unwrap or expose the inner Arc.