Skip to content

Identifier str conversions#259

Closed
LesterEvSe wants to merge 1 commit intoBlockstreamResearch:masterfrom
LesterEvSe:feature/identifier-str-conversions
Closed

Identifier str conversions#259
LesterEvSe wants to merge 1 commit intoBlockstreamResearch:masterfrom
LesterEvSe:feature/identifier-str-conversions

Conversation

@LesterEvSe
Copy link
Copy Markdown
Collaborator

It allows us to easily and ergonomically convert Identifiers to and from standard &str slices across the codebase without having to manually unwrap or expose the inner Arc.

NOTE: This will be needed for future imports.

@LesterEvSe LesterEvSe self-assigned this Mar 27, 2026
@LesterEvSe LesterEvSe requested a review from delta1 as a code owner March 27, 2026 18:13
@LesterEvSe LesterEvSe added the enhancement New feature or request label Mar 27, 2026
@LesterEvSe LesterEvSe changed the title identifier str conversions Identifier str conversions Mar 27, 2026
@gerau
Copy link
Copy Markdown
Contributor

gerau commented Mar 30, 2026

I am not sure if that is even needed, because the same implementations already exist in the wrapped_string! macro:

@LesterEvSe
Copy link
Copy Markdown
Collaborator Author

Okay, I have checked the architecture again and these changes can be removed

@LesterEvSe LesterEvSe closed this Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants