SPLA-3307: Update ConstantAttributeAnalyzer to check for compound assignment#971
Open
SPLA-3307: Update ConstantAttributeAnalyzer to check for compound assignment#971
Conversation
j3parker
reviewed
Apr 2, 2026
| if( @operator is null ) { | ||
| return; | ||
| } | ||
| if( @operator.Parameters.Length != 1 ) { |
Contributor
Author
There was a problem hiding this comment.
No the implicit operator can only have a single parameter. I'll just remove this check
Member
There was a problem hiding this comment.
Oh ok cool. If the answer was "don't know" I would have suggested considering making an "I don't know what happened you need to fix the analyzer" diagnostic for the unexpected scenario, that's worked OK in the past too. But if we know it's not possible then 👍
Contributor
Author
There was a problem hiding this comment.
I checked the microsoft docs and also tried to add an extra parameter to an implicit operator which gave me an error. I'm pretty sure it should be a single parameter but I'll add that diagnostic in though just incase I missed something.
j3parker
previously approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
ConstantAttributeAnalyzerto check for compound assignment.Story: https://desire2learn.atlassian.net/browse/SPLA-3307