[FIX] networking.c: replace DEBUG_OUT integer toggle with CMake opt-in; fix error messages using printf() instead of fprintf(stderr)

[Varadraj75]

In raising this pull request, I confirm the following (please check boxes):

• I have read and understood the contributors guide.
• I have checked that another pull request for this purpose does not exist.
• I have considered, and confirmed that this submission will be valuable to others.
• I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
• I give this submission freely, and claim no ownership to its content.
• I have mentioned this change in the changelog.

My familiarity with the project is as follows (check one):

• I have never used CCExtractor.
• I have used CCExtractor just a couple of times.
• I absolutely love CCExtractor, but have not contributed previously.
• I am an active contributor to CCExtractor.

---

Summary

Fixes #2174 — two related bugs in src/lib_ccx/networking.c.

Fix 1 — Replace DEBUG_OUT integer toggle with CMake opt-in

#define DEBUG_OUT 0 caused debug code to always be compiled into production builds, just silenced at runtime. This is the same pattern fixed for VBI_DEBUG in #2168.

Removed the #define DEBUG_OUT 0 and replaced all #if DEBUG_OUT guards with #ifdefNETWORKING_DEBUG, then added a proper CMake option:

if (NETWORKING_DEBUG)
  add_definitions(-DNETWORKING_DEBUG)
  message(STATUS "Networking debug output enabled")
endif (NETWORKING_DEBUG)

Developers who need networking debug output can now opt in explicitly:

cmake .. -DNETWORKING_DEBUG=ON

Fix 2 — Replace printf() with fprintf(stderr) for error messages

Three error conditions were writing to stdout instead of stderr:

printf("Can't send BIN header\n");   // line 153
printf("Can't send BIN data\n");     // line 180
printf("Unable to send data\n");     // line 240

This means network errors are silently swallowed when stdout is redirected, e.g. ccextractor input.ts > output.srt. All three have been changed to fprintf(stderr, ...), consistent with the rest of the error handling in the same file.

Testing

Built and verified locally on macOS with both NETWORKING_DEBUG=OFF (default) and NETWORKING_DEBUG=ON. All existing CI tests pass.

Fixes #2174

[Copilot]

Pull request overview

This PR addresses #2174 by making networking debug output an explicit CMake opt-in (instead of being always compiled) and by routing networking error messages to stderr.

Changes:

• Replace DEBUG_OUT integer toggle with #ifdef NETWORKING_DEBUG in src/lib_ccx/networking.c.
• Add a NETWORKING_DEBUG CMake option to enable networking debug output at compile time.
• Switch several network send failure messages from printf() (stdout) to fprintf(stderr, ...) (stderr).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File	Description
src/lib_ccx/networking.c	Gates debug logging behind NETWORKING_DEBUG and sends error messages to stderr.
src/CMakeLists.txt	Introduces a CMake option/define to enable NETWORKING_DEBUG.
docs/CHANGES.TXT	Adds a changelog entry for the fixes.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

[Varadraj75]

The Windows CI test failures are pre-existing and unrelated to this PR —
all failing tests show "Last passed: Never" and fail with
Empty path name is not legal, a known Windows test runner path issue
present on every PR.

Both Windows builds (x64 and x86) compile and pass successfully.
Linux CI passes all tests cleanly.

[cfsmp3]

Looks good, but there's a merge conflict in CHANGES.TXT. Please rebase on master. Also, you can drop the CHANGES.TXT entry — this is an internal fix.

Once rebased, we'll merge.

[cfsmp3]

/retest

[ccextractor-bot]

CCExtractor CI platform finished running the test files on linux. Below is a summary of the test results, when compared to test for commit 9f250b1...:

Report Name	Tests Passed
Broken	9/13
CEA-708	1/14
DVB	3/7
DVD	3/3
DVR-MS	2/2
General	23/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	77/86
Teletext	20/21
WTV	13/13
XDS	32/34

Your PR breaks these cases:

• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b...
• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2...
• ccextractor --autoprogram --out=srt --latin1 b22260d065...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65...
• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b...
• ccextractor --out=spupng c83f765c66...
• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9...
• ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e...
• ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065...

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed:

  Test 8738

• ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed:

  Test 8738

• ccextractor --out=srt --latin1 4d4e938ef6..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt 80848c45f8..., Last passed:

  Test 8738

• ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1 --out=srt da904de35d..., Last passed:

  Test 8738

• ccextractor --service 1 --out=sami da904de35d..., Last passed:

  Test 8738

• ccextractor --service 1 --out=ttxt da904de35d..., Last passed:

  Test 8926

• ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service all da904de35d..., Last passed:

  Test 8738

• ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed:

  Test 8738

• ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed:

  Test 8738

• ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed:

  Test 8738

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Test 8738

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Test 8738

• ccextractor --service 1 c83f765c66..., Last passed:

  Test 8738

• ccextractor --myth c83f765c66..., Last passed:

  Test 8738

• ccextractor --in=raw fb79021542..., Last passed:

  Test 8738

• ccextractor --mp4vidtrack 5df914ce77..., Last passed:

  Test 8738

• ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed:

  Test 8738

• ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed:

  Test 8738

Congratulations: Merging this PR would fix the following tests:

• ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.

[ccextractor-bot]

CCExtractor CI platform finished running the test files on windows. Below is a summary of the test results, when compared to test for commit 9f250b1...:

Report Name	Tests Passed
Broken	9/13
CEA-708	1/14
DVB	4/7
DVD	3/3
DVR-MS	2/2
General	25/27
Hardsubx	1/1
Hauppage	3/3
MP4	3/3
NoCC	10/10
Options	81/86
Teletext	20/21
WTV	13/13
XDS	32/34

Your PR breaks these cases:

• ccextractor --autoprogram --out=ttxt --latin1 --ucla --xds 8e8229b88b...
• ccextractor --autoprogram --out=srt --latin1 b22260d065...
• ccextractor --autoprogram --out=ttxt --latin1 --ucla 7aad20907e...
• ccextractor --autoprogram --out=ttxt --xds --latin1 --ucla 85058ad37e...
• ccextractor --autoprogram --out=srt --latin1 --ucla b22260d065...

NOTE: The following tests have been failing on the master branch as well as the PR:

• ccextractor --out=srt --latin1 --autoprogram 73d9313d64..., Last passed:

  Test 8611

• ccextractor --out=ttxt --latin1 001dd8cdf7..., Last passed:

  Test 8611

• ccextractor --out=srt --latin1 4d4e938ef6..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt --no-bom --no-rollup ea83ff7bcb..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt f17524b53f..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt 80848c45f8..., Last passed:

  Test 8611

• ccextractor --service 1 --out=txt --no-bom --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1[EUC-KR] --out=txt --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1 --out=srt da904de35d..., Last passed:

  Test 8611

• ccextractor --service 1 --out=sami da904de35d..., Last passed:

  Test 8611

• ccextractor --service 1 --out=ttxt da904de35d..., Last passed:

  Test 8943

• ccextractor --service 1[EUC-KR] b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1[EUC-KR] --no-rollup b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service all da904de35d..., Last passed:

  Test 8611

• ccextractor --service all[EUC-KR] b5d6aad89f..., Last passed:

  Test 8611

• ccextractor --service 1,2[UTF-8],3[EUC-KR],54 --out=txt da904de35d..., Last passed:

  Test 8611

• ccextractor --autoprogram --out=srt --latin1 d41b53b504..., Last passed:

  Test 8611

• ccextractor --stdout --quiet --no-fontcolor 79a51f3500..., Last passed:

  Test 8611

• ccextractor --stdout --quiet --no-fontcolor 767b546f96..., Last passed:

  Test 8611

• ccextractor --service 1 c83f765c66..., Last passed:

  Test 8611

• ccextractor --myth c83f765c66..., Last passed:

  Test 8611

• ccextractor --in=raw fb79021542..., Last passed:

  Test 8611

• ccextractor --mp4vidtrack 5df914ce77..., Last passed:

  Test 8611

• ccextractor --xmltv=3 --out=null 96efd279cf..., Last passed:

  Test 8611

• ccextractor --datapid 2310 --autoprogram --out=srt --latin1 e639e54550..., Last passed:

  Test 8611

Congratulations: Merging this PR would fix the following tests:

• ccextractor --autoprogram --out=srt --latin1 --quant 0 85271be4d2..., Last passed: Never
• ccextractor --autoprogram --out=ttxt --latin1 --ucla dab1c1bd65..., Last passed: Never
• ccextractor --out=srt --latin1 --autoprogram 29e5ffd34b..., Last passed: Never
• ccextractor --out=spupng c83f765c66..., Last passed: Never
• ccextractor --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsnotbefore 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsnotafter 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsforatleast 1 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never
• ccextractor --startcreditsforatmost 2 --startcreditstext "CCextractor Start crdit Testing" c4dd893cb9..., Last passed: Never

It seems that not all tests were passed completely. This is an indication that the output of some files is not as expected (but might be according to you).

Check the result page for more info.