improve ABNF pattern integration: add autogeneration via Makefile#1065
Closed
bernhardreiter wants to merge 2 commits intoCERTCC:mainfrom
Closed
improve ABNF pattern integration: add autogeneration via Makefile#1065bernhardreiter wants to merge 2 commits intoCERTCC:mainfrom
bernhardreiter wants to merge 2 commits intoCERTCC:mainfrom
Conversation
* add abnf-to-regexp as requirement * split namespace_patterns.py out from patterns.py as file that can be generated fully
* add Makefile rule * add autogeneration warning to namespace_patterns.py resolve CERTCC#899
bernhardreiter
requested review from
ahouseholder,
cgyarbrough and
sei-vsarvepalli
as code owners
This was referenced Feb 19, 2026
Contributor
Author
|
/!\ only merge either #1067 or this request. |
Contributor
|
Intend to merge #1067 |
ahouseholder
added a commit
that referenced
this pull request
Mar 27, 2026
… namespace_patterns.py - Move abnf-to-regexp from runtime to dev dependency group in pyproject.toml - Replace dynamic ABNF parsing in patterns.py with static import from namespace_patterns.py (no runtime dependency on abnf-to-regexp) - Add namespace_patterns.py with pre-generated static regex patterns - Add Makefile rule to regenerate namespace_patterns.py from ABNF source - Add --no-dev to 'uv sync --frozen' in Dockerfile dependencies stage so abnf-to-regexp (and its sdist-only regex==2021.4.4 dep) are not installed in production images - Add gcc+libc-dev to test stage for compiling regex when running dev sync Fixes docker-compose --project-directory docker build --no-cache Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Captured this branch into #1101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #899