Add ADR-0014: Terminology shift from "decision tree" to "decision table"#1100
Add ADR-0014: Terminology shift from "decision tree" to "decision table"#1100
Conversation
Agent-Logs-Url: https://github.com/CERTCC/SSVC/sessions/429c6ccb-379d-4ca6-ab3d-14c95415f27c Co-authored-by: sei-renae <190382933+sei-renae@users.noreply.github.com>
sei-renae
left a comment
sei-renae
left a comment
There was a problem hiding this comment.
ready for more human review
sei-renae
requested review from
ahouseholder,
cgyarbrough,
j--- and
sei-vsarvepalli
as code owners
There was a problem hiding this comment.
Pull request overview
Adds a new Architecture Decision Record (ADR-0014) documenting the project-wide terminology shift from “decision tree” to “decision table”, and updates the ADR index so it appears under Accepted Records.
Changes:
- Added ADR-0014 describing the rationale and consequences of adopting “decision table” terminology.
- Updated the ADR index to include ADR-0014 under Accepted Records.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docs/adr/index.md | Adds ADR-0014 link to the Accepted Records list. |
| docs/adr/0014-use-decision-table-terminology.md | New ADR documenting the terminology decision and its implications. |
| --- | ||
| status: "accepted" | ||
| date: 2025-08-26 | ||
| --- |
There was a problem hiding this comment.
The ADR frontmatter date (2025-08-26) doesn’t match the PR description (2025-09-17). Please align the ADR’s date field with the intended acceptance/last-updated date (or adjust the PR description if 2025-08-26 is correct).
|
|
||
| ## Decision Outcome | ||
|
|
||
| Chosen option: 'Switch to "decision table"' |
There was a problem hiding this comment.
In this repo’s ADRs/template, the Chosen option: line consistently uses double quotes without additional nested quoting. Here it’s written as Chosen option: 'Switch to "decision table"', which is inconsistent and a bit harder to read; consider switching to the standard quoting format used in other ADRs (see docs/adr/_template.md).
| Chosen option: 'Switch to "decision table"' | |
| Chosen option: "Switch to decision table" |
|
|
||
| ### Rationale | ||
|
|
||
| "Decision table"accurately describes the tabular structure used by |
There was a problem hiding this comment.
Missing space after the closing quote: "Decision table"accurately should be "Decision table" accurately.
| "Decision table"accurately describes the tabular structure used by | |
| "Decision table" accurately describes the tabular structure used by |
| ## Considered Options | ||
|
|
||
| - Switch to "decision framework" | ||
| - Switch to "decision table" | ||
|
|
There was a problem hiding this comment.
The PR description says three options were considered (keep, switch, or use both with disambiguation), but the ADR lists only two options under “Considered Options”. Either add the missing option(s) to the ADR or update the PR description so they match.
Adds an ADR documenting the decision made in v2025.9 to replace "decision tree" with "decision table" — avoiding collision with the ML/statistics meaning of "decision tree" (supervised learning via recursive feature partitioning).
Changes
docs/adr/0014-use-decision-table-terminology.md— New MADR-format ADR (status: accepted, date: 2025-09-17) covering:docs/adr/index.md— Added ADR-0014 to the Accepted Records list⌨️ Start Copilot coding agent tasks without leaving your editor — available in VS Code, Visual Studio, JetBrains IDEs and Eclipse.