Skip to content

Docker borkened#1102

Open
sei-renae wants to merge 3 commits intomainfrom
docker-borkened
Open

Docker borkened#1102
sei-renae wants to merge 3 commits intomainfrom
docker-borkened

Conversation

@sei-renae
Copy link
Copy Markdown
Contributor

Fix local build and docker build
This pull request makes several dependency and codebase changes to remove the use of the abnf-to-regexp library and instead directly include the generated regular expression code for parsing namespace patterns. This simplifies the codebase and reduces external dependencies.

Dependency and import changes:

  • Removed the abnf-to-regexp dependency from both the pyproject.toml dependencies list and from imports in src/ssvc/utils/patterns.py. ([[1]](https://github.com/CERTCC/SSVC/pull/1102/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711L51), [[2]](https://github.com/CERTCC/SSVC/pull/1102/files#diff-b97f367a184861197f4c084fc982264a59150a04247f931c349524d9e26eeadcL24-L27))

Pattern generation refactor:

  • Replaced the dynamic generation of regex patterns (previously using abnf-to-regexp at runtime) with a static, directly-included Python section containing the generated regex code for namespace patterns in src/ssvc/utils/patterns.py. ([src/ssvc/utils/patterns.pyL44-R73](https://github.com/CERTCC/SSVC/pull/1102/files#diff-b97f367a184861197f4c084fc982264a59150a04247f931c349524d9e26eeadcL44-R73))

Dependency version pinning:

  • Pinned the mkdocstrings-python dependency to a maximum version of 2.0.3 in pyproject.toml to avoid incompatibilities with newer versions. ([pyproject.tomlL36-R36](https://github.com/CERTCC/SSVC/pull/1102/files#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711L36-R36))

Copilot AI review requested due to automatic review settings March 27, 2026 18:36
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates SSVC’s namespace-pattern regex implementation to avoid runtime code generation and removes the abnf-to-regexp dependency, aiming to fix local/Docker builds by simplifying dependencies and pinning a docs-related package version.

Changes:

  • Replaced runtime ABNF-to-regex generation with a statically inlined, generated regex component block for namespace parsing.
  • Removed abnf-to-regexp from project dependencies and corresponding imports.
  • Added an upper-bound pin for mkdocstrings-python to avoid incompatibilities with newer releases.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/ssvc/utils/patterns.py Removes abnf-to-regexp usage and embeds the generated namespace regex code directly.
pyproject.toml Drops abnf-to-regexp dependency and pins mkdocstrings-python with an upper bound.

"mkdocs-material-extensions>=1.3.1",
"mkdocstrings>=0.30.0",
"mkdocstrings-python>=1.17.0",
"mkdocstrings-python<=2.0.3",
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mkdocstrings-python is now only constrained with an upper bound (<=2.0.3). Dropping the previous lower bound can allow dependency resolution to pick an older (potentially incompatible) mkdocstrings-python release, which can break docs builds. Consider restoring a lower bound (e.g., keep the prior >=1.17.0 while adding the new max) so the supported range is explicit.

Suggested change
"mkdocstrings-python<=2.0.3",
"mkdocstrings-python>=1.17.0,<=2.0.3",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants