ENH: adding euclid clusters tutorial#284
Draft
bsipocz wants to merge 8 commits intoCaltech-IPAC:mainfrom
Draft
Conversation
Contributor
|
@bsipocz do you want me to look at how to shorten the runtime of this notebook? and also do you want me to look into adding narrative text? or do you already have a plan? |
Member
Author
|
I would appreciate any help, thanks for offering. |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
Author
|
@jkrick - you should be able to directly push to this branch. Based on what you showed today I think will know how to do that, but please ping me if you need any help. |
Member
Author
|
Runtime actually doesn't look as bad on CI, I'm not sure why I had more issues locally. That being said if there is a reasonable way, maybe we could still cut it back to ~half? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR for now as the notebook runs way too long as is (2+hr locally)
TODO (that came up during making this PR, we may have other things left from the initial review):
Extra things that are definitely not merging blockers, but what would make an improvement:
lxmllibrary)seaborn, as it is now a new dependency. If we were to use it in other notebooks, too then that's fine, but if it will be only this one, then I think we should reconsider to stay with mpl.Resolves #282
Closes #283