IRSA-7633 prevent strings from being misclassified as arrays in variant visitor#5
Open
sreenivasapydi wants to merge 1 commit intoCaltech-IPAC:masterfrom
Open
IRSA-7633 prevent strings from being misclassified as arrays in variant visitor#5sreenivasapydi wants to merge 1 commit intoCaltech-IPAC:masterfrom
sreenivasapydi wants to merge 1 commit intoCaltech-IPAC:masterfrom
Conversation
sreenivasapydi
changed the title
sreenivasapydi
commented
Mar 17, 2026
|
|
||
| class Variant_converter_visitor : public boost::static_visitor<Variant> { | ||
| public: | ||
| Variant operator()(const String_type& value) const { return value; } |
Author
There was a problem hiding this comment.
the unit tests fails without the fix, as on debian12 and newer c++
what(): get_value< string > called on Array Value
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.